Using Read/Write Lock guard in all corresponding places #7148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9bde33 to
5951abd
Compare
The problem in many places is that RocksDB uses Read/Write locks in non safe mode. This PR protects corresponding places with corresponding guards.
5951abd to
8a690ef
Compare
|
@ajkr may I have any chance for review ? |
|
Lock guards should always be used in C++ code that may throw. I forget if rocksdb is compiled with exceptions (I think it may not be?). Regardless lack of use of lock guards in modern C++ is in general a code smell... so this PR or something like it should be considered! |
Sign up for free
to join this conversation on GitHub.
Alr
5C32
eady have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in many places is that RocksDB uses Read/Write locks in non safe mode.
This PR protects corresponding places with corresponding guards.