8000 updated Timber dependency version to 4.1.2 by mohsenoid · Pull Request #393 · facebook/stetho · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

updated Timber dependency version to 4.1.2 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

updated Timber dependency version to 4.1.2 #393

wants to merge 0 commits into from

Conversation

mohsenoid
Copy link

this old Timber version causes me many troubles,
so please merge this new version fix

@ghost ghost added the CLA Signed label Jun 2, 2016
@jasta
Copy link
Contributor
jasta commented Jun 2, 2016

Can you squash your diffs into one now that it's only a simple 2 line patch?

@mohsenoid
Copy link
Author

I don't know what do you mean! and what should I do...

@jasta
Copy link
Contributor
jasta commented Jun 3, 2016

Your current PR is comprised of 5 individual git commits, even though most of them are now "empty" because I already made the changes contained within them. Git offers a feature to let you merge those into 1 so that it looks cleaner in our version control tree:

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@mohsenoid mohsenoid closed this Jun 4, 2016
@mohsenoid
Copy link
A021 Author

Hi,
I create a new pull request:
update timber version #396

@mohsenoid
Copy link
Author

Hi,

I create a new pull request:
update timber version #396 #396

I hope everything goes fine.

Best regards,

Mohsen Mirhoseini Argi

On 04 Jun 2016, at 02:16, Josh Guilfoyle notifications@github.com wrote:

Your current PR is comprised of 5 individual git commits, even though most of them are now "empty" because I already made the changes contained within them. Git offers a feature to let you merge those into 1 so that it looks cleaner in our version control tree:

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #393 (comment), or mute the thread https://github.com/notifications/unsubscribe/AE5cr0dSBYkIYCtX2hky7qAPny1hRoQfks5qIKCkgaJpZM4IsL9f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohsenoid @jasta
0