8000 [babel-plugin] add LTR/RTL config to legacy-e… by mellyeliu · Pull Request #1083 · facebook/stylex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[babel-plugin] add LTR/RTL config to legacy-e… #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
+1,850 −481
Merged

[babel-plugin] add LTR/RTL config to legacy-e… #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49089ce
[babel-plugin] add ltr/rtl config to legacy-expand-shorthands
mellyeliu May 28, 2025
dc6ef81
[babel-plugin] remove nonstandard logical styles from legacy-expand-s…
mellyeliu May 28, 2025
fc0a969
[babel-plugin] move nonstandard polyfill tests to legacy path
mellyeliu May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-legacy-shorthands-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ function transform(source, opts = {}) {
{
runtimeInjection: true,
styleResolution: 'legacy-expand-shorthands',
enableLogicalStylesPolyfill: true,
...opts,
},
],
Expand All @@ -53,19 +54,19 @@ describe('Legacy-shorthand-expansion resolution', () => {
var _inject2 = _inject;
import stylex from 'stylex';
_inject2(".x123j3cw{padding-top:5px}", 4000);
_inject2(".x1mpkggp{padding-right:5px}", 3000, ".x1mpkggp{padding-left:5px}");
_inject2(".x1gabggj{padding-right:5px}", 3000, ".x1gabggj{padding-left:5px}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm can we avoid having these hashes change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm actually not sure why these are changing and have to investigate...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just dug into this a bit. in the stylex-create visitor, we build the hash using the property name after shorthand expansion (padding -> padding-top, padding-start), but before ltr/rtl polyfill (see below).

the hashes changed because i made a change to expand to padding-inline-start instead of padding-start, but the polyfill later changes it back to paddingLeft and paddingRight

_inject2(".xs9asl8{padding-bottom:5px}", 4000);
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
export const styles = {
foo: {
kLKAdn: "x123j3cw",
kP0aTx: "x1mpkggp",
kwRFfy: "x1gabggj",
kGO01o: "xs9asl8",
kuDDbn: "x1t2a60a",
kZCmMZ: "xaso8d8",
$$css: true
}
};
"x123j3cw x1mpkggp xs9asl8 x1t2a60a";"
"x123j3cw x1gabggj xs9asl8 xaso8d8";"
`);
});
test('stylex call with short-form property collisions', () => {
Expand All @@ -91,13 +92,13 @@ describe('Legacy-shorthand-expansion resolution', () => {
import stylex from 'stylex';
_inject2(".x123j3cw{padding-top:5px}", 4000);
_inject2(".xs9asl8{padding-bottom:5px}", 4000);
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".x1iji9kk{padding-right:10px}", 3000, ".x1iji9kk{padding-left:10px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
_inject2(".x2vl965{padding-right:10px}", 3000, ".x2vl965{padding-left:10px}");
_inject2(".x1nn3v0j{padding-top:2px}", 4000);
_inject2(".xg83lxy{padding-right:2px}", 3000, ".xg83lxy{padding-left:2px}");
_inject2(".x14vy60q{padding-right:2px}", 3000, ".x14vy60q{padding-left:2px}");
_inject2(".x1120s5i{padding-bottom:2px}", 4000);
_inject2(".x1sln4lm{padding-left:10px}", 3000, ".x1sln4lm{padding-right:10px}");
"x1nn3v0j xg83lxy x1120s5i x1sln4lm";"
_inject2(".xe2zdcy{padding-left:10px}", 3000, ".xe2zdcy{padding-right:10px}");
"x1nn3v0j x14vy60q x1120s5i xe2zdcy";"
`);
});
test('stylex call with short-form property collisions with null', () => {
Expand All @@ -123,12 +124,12 @@ describe('Legacy-shorthand-expansion resolution', () => {
import stylex from 'stylex';
_inject2(".x123j3cw{padding-top:5px}", 4000);
_inject2(".xs9asl8{padding-bottom:5px}", 4000);
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".x1iji9kk{padding-right:10px}", 3000, ".x1iji9kk{padding-left:10px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
_inject2(".x2vl965{padding-right:10px}", 3000, ".x2vl965{padding-left:10px}");
_inject2(".x1nn3v0j{padding-top:2px}", 4000);
_inject2(".xg83lxy{padding-right:2px}", 3000, ".xg83lxy{padding-left:2px}");
_inject2(".x14vy60q{padding-right:2px}", 3000, ".x14vy60q{padding-left:2px}");
_inject2(".x1120s5i{padding-bottom:2px}", 4000);
"x1nn3v0j xg83lxy x1120s5i";"
"x1nn3v0j x14vy60q x1120s5i";"
`);
});
});
Expand All @@ -148,18 +149,18 @@ describe('Legacy-shorthand-expansion resolution', () => {
"import _inject from "@stylexjs/stylex/lib/stylex-inject";
var _inject2 = _inject;
import stylex from 'stylex';
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".x1mpkggp{padding-right:5px}", 3000, ".x1mpkggp{padding-left:5px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
_inject2(".x1gabggj{padding-right:5px}", 3000, ".x1gabggj{padding-left:5px}");
export const styles = {
foo: {
kuDDbn: "x1t2a60a",
kP0aTx: "x1mpkggp",
kZCmMZ: "xaso8d8",
kwRFfy: "x1gabggj",
kE3dHu: null,
kpe85a: null,
$$css: true
}
};
"x1t2a60a x1mpkggp";"
"xaso8d8 x1gabggj";"
`);
});
test('stylex call with short-form property collisions', () => {
Expand All @@ -185,13 +186,13 @@ describe('Legacy-shorthand-expansion resolution', () => {
import stylex from 'stylex';
_inject2(".x123j3cw{padding-top:5px}", 4000);
_inject2(".xs9asl8{padding-bottom:5px}", 4000);
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".x1iji9kk{padding-right:10px}", 3000, ".x1iji9kk{padding-left:10px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
_inject2(".x2vl965{padding-right:10px}", 3000, ".x2vl965{padding-left:10px}");
_inject2(".x1nn3v0j{padding-top:2px}", 4000);
_inject2(".xg83lxy{padding-right:2px}", 3000, ".xg83lxy{padding-left:2px}");
_inject2(".x14vy60q{padding-right:2px}", 3000, ".x14vy60q{padding-left:2px}");
_inject2(".x1120s5i{padding-bottom:2px}", 4000);
_inject2(".x1sln4lm{padding-left:10px}", 3000, ".x1sln4lm{padding-right:10px}");
"x1nn3v0j xg83lxy x1120s5i x1sln4lm";"
_inject2(".xe2zdcy{padding-left:10px}", 3000, ".xe2zdcy{padding-right:10px}");
"x1nn3v0j x14vy60q x1120s5i xe2zdcy";"
`);
});
test('stylex call with short-form property collisions with null', () => {
Expand All @@ -217,12 +218,12 @@ describe('Legacy-shorthand-expansion resolution', () => {
import stylex from 'stylex';
_inject2(".x123j3cw{padding-top:5px}", 4000);
_inject2(".xs9asl8{padding-bottom:5px}", 4000);
_inject2(".x1t2a60a{padding-left:5px}", 3000, ".x1t2a60a{padding-right:5px}");
_inject2(".x1iji9kk{padding-right:10px}", 3000, ".x1iji9kk{padding-left:10px}");
_inject2(".xaso8d8{padding-left:5px}", 3000, ".xaso8d8{padding-right:5px}");
_inject2(".x2vl965{padding-right:10px}", 3000, ".x2vl965{padding-left:10px}");
_inject2(".x1nn3v0j{padding-top:2px}", 4000);
_inject2(".xg83lxy{padding-right:2px}", 3000, ".xg83lxy{padding-left:2px}");
_inject2(".x14vy60q{padding-right:2px}", 3000, ".x14vy60q{padding-left:2px}");
_inject2(".x1120s5i{padding-bottom:2px}", 4000);
"x1nn3v0j xg83lxy x1120s5i";"
"x1nn3v0j x14vy60q x1120s5i";"
`);
});
});
Expand Down
Loading
0