8000 Improve importSources docs by necolas · Pull Request #1109 · facebook/stylex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve importSources docs #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve importSources docs #1109

wants to merge 1 commit into from
+4 −3

Conversation

necolas
Copy link
Contributor
@necolas necolas commented Jun 26, 2025

Add the missing object syntax.

See discussion #1106

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@necolas necolas force-pushed the docs/importSources branch from 39bfa53 to cd55564 Compare June 26, 2025 21:16
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 26, 2025 •
edited
Loading

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.13.1 compare
node ./compare.js /tmp/tmp.BMJjfFb9LX /tmp/tmp.EDyUCcRVBC

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 625 613 0.98 -
· complex create 206 206 1.00
babel-plugin: stylex.createTheme
· basic themes 448 447 1.00 -
· complex themes 42 41 0.98 -

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 26, 2025 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.13.1 compare
node ./compare.js /tmp/tmp.jO8WNsT3qJ /tmp/tmp.jUJlGUFJsy

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,222 1,222 1.00
· minified 3,679 3,679 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,227 1,227 1.00
· minified 3,224 3,224 1.00
benchmarks/size/.build/bundle.js
· compressed 495,990 495,990 1.00
· minified 4,843,460 4,843,460 1.00
benchmarks/size/.build/stylex.css
· compressed 100,374 100,374 1.00
· minified 754,717 754,717 1.00

@necolas
Improve importSources docs
cba62ac 
Add the missing object syntax
@necolas necolas force-pushed the docs/importSources branch from cd55564 to cba62ac Compare June 26, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jta26 Jta26 Awaiting requested review from Jta26 Jta26 is a code owner

@mellyeliu mellyeliu Awaiting requested review from mellyeliu mellyeliu is a code owner

@vincentriemer vincentriemer Awaiting requested review from vincentriemer vincentriemer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@necolas @facebook-github-bot
0