8000 Make zstd.h compatible with -Wzero-as-null-pointer-constant by r-barnes · Pull Request #4034 · facebook/zstd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make zstd.h compatible with -Wzero-as-null-pointer-constant #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

Make zstd.h compatible with -Wzero-as-null-pointer-constant #4034

merged 2 commits into from
Apr 29, 2024

Conversation

r-barnes
Copy link
Contributor
@r-barnes r-barnes commented Apr 26, 2024 •
edited
Loading

Makes this place nicely when header is used in C++ Files.

Cyan4973
Cyan4973 requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code needs to compile properly on a large base of C90 compilers.
Please write this modification in a more portable way.

@r-barnes
Copy link
Contributor Author

@Cyan4973 - It looks good now. @terrelln seems happy with the associated D56650471.

Cyan4973
Cyan4973 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@terrelln
Copy link
Contributor

Thanks @r-barnes!

@terrelln terrelln merged commit 97291fc into facebook:dev Apr 29, 2024
@r-barnes r-barnes deleted the patch-1 branch May 24, 2024 16:21
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-barnes @terrelln @Cyan4973 @facebook-github-bot
0