8000 [cli] Allowing stdin on --patch-from using --stream-size by bimbashrestha · Pull Request #2206 · facebook/zstd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[cli] Allowing stdin on --patch-from using --stream-size #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2020
Merged

[cli] Allowing stdin on --patch-from using --stream-size #2206

merged 3 commits into from
Jun 18, 2020

Conversation

bimbashrestha
Copy link
Contributor

Closes #2195

A further refinement might be to guess the size of src when not provided by --stream-size. The src size won't be much bigger than the dict size so we could potentially pick dictSize + SOME_PADDING.

@bimbashrestha
Copy link
Contributor Author

The ci failure looks unrelated. I'm going to repush to make sure it is

@bimbashrestha bimbashrestha merged commit c496fd2 into facebook:dev Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--patch-from fails to work on pipes
3 participants
@bimbashrestha @Cyan4973 @facebook-github-bot
0