This repository was archived by the owner on Sep 1, 2024. It is now read-only.
Added sequence iterator #91
< 8000 /div>
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts functionality to mbrl.util.common.get_basic_iterators().
d615714 to
3c220e5
Compare
freiberg-roman
suggested changes
Jun 13, 2021
freiberg-roman
suggested changes
Jun 15, 2021
freiberg-roman
approved these changes
Jun 16, 2021
10000
jan1854
reviewed
Jul 2, 2021
jan1854
reviewed
Jul 5, 2021
…equence_buffer_iterator() util.
…aining/validation splits.
…s_per_loop of training and validation buffers.
Fixed a bug where SequenceTransitionIterator.__len__() ignores max_batches_per_loop
…er_iterator() stores trajectory information
Fixed a bug where a default argument to get_sequence_buffer_iterator causes a crash and added an assertion for clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Added an iterator class that returns sequences of transitions.
This also deprecates method
ReplayBuffer.get_iterators()and replaces it with a utility function inmbrl.util.commonpackage.Motivation and Context / Related issue
This is a core component of #88 and #86.
How Has This Been Tested (if it applies)
I added unit tests for the iterator and the new utilities added, which check that the trajectories returned are consistent with the trajectories stored in the replay buffer.
Checklist