8000 Declare AnyRPC::anyrpc library link private by mablanchard · Pull Request #58 · faaxm/spix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Declare AnyRPC::anyrpc library link private #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Declare AnyRPC::anyrpc library link private #58

merged 1 commit into from
Apr 19, 2022

Conversation

mablanchard
Copy link
Contributor
@mablanchard mablanchard commented Apr 15, 2022 •
edited
Loading

Spix public API does not expose/leak any AnyRPC symbols, the Spix to AnyRPC library link can be made private.

@mablanchard
< 8000 span class="Button-label"> Copy link
Contributor Author

This prevent generated SpixTargets.cmake to declare an AnyRPC::anyrpc link dependency by public transitivity.

@faaxm
Copy link
Owner
faaxm commented Apr 17, 2022

@mablanchard Thank you! Could you have a look at the failing builds?

@mablanchard
Copy link
Contributor Author

Should be better now...

faaxm
faaxm approved these changes Apr 19, 2022
View reviewed changes
Copy link
Owner
@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing!

@faaxm faaxm merged commit 368793a into faaxm:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faaxm faaxm faaxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mablanchard @faaxm
0