8000 Find objects by id by krussjos · Pull Request #34 · faaxm/spix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Find objects by id #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2021
Merged

Find objects by id #34

merged 8 commits into from
Jun 17, 2021

Conversation

krussjos
Copy link
Contributor
@krussjos krussjos commented Jun 14, 2021 •
edited
Loading

I didn't like how you have to set an objectName for every single item you want to control. Added some code to allow finding objects by object id. If an objectName is found, id takes priority over the item id.

Fixes #33

@krussjos krussjos mentioned this pull request Jun 14, 2021
Closed
m-kuhn
m-kuhn reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor
@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

If you add "Fixes #33" to the pull request message, it will automatically close the issue on merge.

@faaxm
Copy link
Owner
faaxm commented Jun 15, 2021 •
edited
Loading

Generally support the idea but have to find some time to properly review it.

Please run clang-format (there's a script in ./devtools). Normally the travis-ci build would detect this, but I realise that one's broken right now.

And of course, thanks for contributing! :)

@krussjos
Copy link
Contributor Author

clang
Done. Sorry should've have done so before.

faaxm
faaxm requested changes Jun 16, 2021
View reviewed changes
Copy link
Owner
@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Just had a few comments. Hope you don't mind my style nit-picking 😉

faaxm
faaxm reviewed Jun 17, 2021
View reviewed changes
faaxm
faaxm approved these changes Jun 17, 2021
View reviewed changes
Copy link
Owner
@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! And thank you so much for the work 😃

@faaxm faaxm merged commit ffeaf2d into faaxm:master Jun 17, 2021
m-kuhn pushed a commit to opengisch/spix that referenced this pull request Aug 10, 2021
@krussjos @m-kuhn
Find objects by id (faaxm#34)
76c799f 
* user object id instead of objectName to identify items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn left review comments

@faaxm faaxm faaxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get items by id
3 participants
@krussjos @faaxm @m-kuhn
0