8000 SIM-2799: Receive the model name in the ActionsRequest and override t… by fablechris · Pull Request #35 · fablestudio/fable-saga · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SIM-2799: Receive the model name in the ActionsRequest and override t… #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2024
Merged

SIM-2799: Receive the model name in the ActionsRequest and override t… #35

merged 3 commits into from
Jan 5, 2024

Conversation

fablechris
Copy link
Contributor

…he model before running the chain if necessary.

SIM-2799: Receive the model name in the ActionsRequest and override t…
08d04d5 
…he model before running the chain if necessary.
@fablechris fablechris requested a review from frankcarey January 4, 2024 19:20
frankcarey
frankcarey approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor
@frankcarey frankcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankcarey
Copy link
Contributor

Actually, can we add a test for this?

@frankcarey frankcarey merged commit 57c1610 into main Jan 5, 2024
@frankcarey frankcarey deleted the SIM-2799-send-model-to-saga branch January 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcarey frankcarey frankcarey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fablechris @frankcarey
0