8000 use SPC to manage workspace directory by siosw · Pull Request #293 · fabriqnetwork/specular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use SPC to manage workspace directory #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

use SPC to manage workspace directory #293

wants to merge 23 commits into from

Conversation

siosw
Copy link
Contributor
@siosw siosw commented Jan 25, 2024 •
edited
Loading

Goals of PR

when running locally, instead of manually copying a workspace dir, this should be managed through SPC

TODO:

  • document how to download workspaces etc...
  • start all services through SPC
  • download SPC binary as part of the CI pipeline

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jan 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c41fb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@macwis
Copy link
Contributor
macwis commented Jan 25, 2024

that's great, let's just get the spc binary with wget which should bring the e2e to work and we're set!

@siosw siosw force-pushed the siosw/spc-integration branch 6 times, most recently from 6921a0d to b6c1dbd Compare February 5, 2024 16:35
siosw
siosw commented Feb 6, 2024
View reviewed changes
sbin/run_e2e_tests.sh
$SBIN/start_sp_geth.sh -c &>proc.out &
sleep 1
$SBIN/start_sp_geth.sh -c &>$WORKSPACE_DIR/sp_geth.out &
sleep 4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reasons the tests fail with sleep 1 - i would like to get rid of the hardcoded waiting and rely on wait files. should I try implementing this for this PR or should this go in the backlog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now

@siosw siosw marked this pull request as ready for review February 7, 2024 11:17
@siosw siosw force-pushed the siosw/spc-integration branch from bf8bbde to 1fbd380 Compare February 7, 2024 11:33
@siosw siosw force-pushed the siosw/spc-integration branch 2 times, most recently from 29701dc to 7f43fde Compare February 9, 2024 11:06
@siosw siosw force-pushed the siosw/spc-integration branch from 7f43fde to 4f4d1bd Compare February 9, 2024 11:56
@macwis
Copy link
Contributor
macwis commented Feb 9, 2024

We might need to add the spc installation in the docker images in CI/CD pipelines, otherwise the command won't be available there.

@siosw siosw mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macwis macwis macwis approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siosw @macwis
0