fix(locale): rename ja and zh_CN company affix files #3448
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3448 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2825 2825
Lines 217571 217571
Branches 952 949 -3
==========================================
- Hits 217518 217516 -2
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
|
@matsueushi I see that this was your first contribution to our project.
|
|
I’m sorry for my late reply. I often use Faker in my projects, and I wanted to improve the quality of Japanese test data. That was my main motivation. Yes, I read the contributing documentation before starting. It was very helpful and easy to follow. Thanks to the well-prepared devcontainer, the development environment was easy to set up. The process was quite clear, and I didn’t have many problems. The review process was smooth and clear. I didn’t feel lost or confused during it. Thank you for maintaining such a great project. I’d love to contribute more in the future if I get the chance! |
|
@matsueushi Oh that is very good feedback for us and very good to know that persons are actually using the devcontainer 👍 |
In #2975, most locales moved company affixes to
legal_entity_type.ts, but the Japanese (ja) and Simplified Chinese (zh_CN) locales were left usingtype.ts.This commit corrects that by aligning these locale with other languages.