8000 feat(locale): add Japanese sex definitions for person locale by noritaka1166 · Pull Request #3495 · faker-js/faker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(locale): add Japanese sex definitions for person locale #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

noritaka1166
Copy link
Contributor

add Japanese sex definitions for person locale

@noritaka1166 noritaka1166 requested a review from a team as a code owner April 30, 2025 16:44
Copy link
netlify bot commented Apr 30, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit edc06d1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68125377b7cdb10008bbf912
😎 Deploy Preview https://deploy-preview-3495.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (8c0953a) to head (edc06d1).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3495      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2872     2876       +4     
  Lines      219865   220587     +722     
  Branches      952      950       -2     
==========================================
+ Hits       219812   220532     +720     
- Misses         53       55       +2     
Files with missing lines Coverage Δ
src/locales/ja/person/index.ts 100.00% <100.00%> (ø)
src/locales/ja/person/sex.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels May 2, 2025
@xDivisionByZerox xDivisionByZerox added this to the v9.x milestone May 2, 2025
@xDivisionByZerox xDivisionByZerox merged commit 1dbd8fa into faker-js:next May 2, 2025
26 checks passed
@noritaka1166 noritaka1166 deleted the add-japanese-person-sex branch May 23, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0