Html generator for Faker #2769
Merged
Html generator for Faker #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thdaraujo, Have added the documentation and fixed the flaky spec #2798 as well, Please check. 😄 |
thdaraujo
reviewed
Jul 11, 2023
|
@thdaraujo Have resolved your comments, Please take a look. 😄 |
|
@stefannibrasil I have added the version and addressed your comments. Please check. |
There was a problem hiding this comment.
@ruban-thilak thank you for the changes! I had more time today to test the generators. Looking good, just added a few more comments.
|
@stefannibrasil I have made the suggested changes. Please take a look. |
stefannibrasil
approved these changes
Aug 7, 2023
vbrazo
reviewed
Aug 9, 2023
|
Is there a timeline to publish v 3.2.1? (I know this is only 2 days old, so not trying to pester) |
|
I'm planning on doing a release this Friday. In the meantime, feel free use the main branch. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because Faker doesn't have an html generator, and this can be used for testing HTML sanitizers or email bodies containing HTML, etc.
Additional information
I implemented this generator by referring to the existing implementation of the markdown generator available in Faker.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator: