get rid of inplace operation and warning #4061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
|
I am currently trying to fix this issue as well. When I use the method you use in this pull request, it does get rid of the warning. But there seem to be some issues with the na_dict when fixing in this way. In the dataset I am using for validation (https://www.kaggle.com/c/house-prices-advanced-regression-techniques/data), missing values that should be getting filled with a median of 0 are being filled with 136 instead (This is referring to the MasVnrArea column, and taking into consideration only the rows that are in the TabularPandas training set when determining the median). |
|
Update: the na_dict seems fine. The issue is arising elsewhere. Notebook demonstrating this pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4043
I tried to make the change in the notebook but ran into a Module Not Found error (get_embeddings) . I couldn't figure out how to fix that so here's the change directly in the py file.