10000 feat: export `FastifyOtelInstrumentationOpts` by satazor · Pull Request #54 · fastify/otel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: export FastifyOtelInstrumentationOpts #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

feat: export FastifyOtelInstrumentationOpts #54

merged 1 commit into from
May 11, 2025

Conversation

satazor
Copy link
Contributor
@satazor satazor commented May 4, 2025 •
edited
Loading

Had to change export logic to make it possible to export types.

Closes #53

Checklist

@satazor
Copy link
Contributor Author
satazor commented May 4, 2025

Let me know if this is fine or shall I export other types that were removed in d3a885b

@satazor satazor force-pushed the feature/export-instrumention-options branch 3 times, most recently from d73f15d to ebc5def Compare May 4, 2025 12:17
metcoder95
metcoder95 reviewed May 5, 2025
View reviewed changes
Copy link
Member
@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linting issues and add some testing around the new exported type?

@satazor satazor force-pushed the feature/export-instrumention-options branch from ebc5def to 87d6695 Compare May 9, 2025 20:41
@satazor
Copy link
Contributor Author
satazor commented May 9, 2025

Should be fixed

@satazor satazor force-pushed the feature/export-instrumention-options branch from 87d6695 to 2f58e66 Compare May 9, 2025 20:43
@metcoder95 metcoder95 merged commit f2f7a46 into fastify:main May 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@diogotorres97 diogotorres97 diogotorres97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export FastifyOtelInstrumentationOpts
3 participants
@satazor @metcoder95 @diogotorres97
0