8000
-
Notifications
You must be signed in to change notification settings - Fork 67
breaking: remove assemblyscript #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c3d47c
to
c62e65b
Compare
5b01480
to
a0b12a1
Compare
cde0ec6
to
d775fa7
Compare
9ee4118
to
4b35562
Compare
3a6e651
to
2a63819
Compare
c05b52b
to
ff65e7a
Compare
ff65e7a
to
99bfa62
Compare
99bfa62
to
07ff920
Compare
d52b6f5
to
f2fe7eb
Compare
kpfleming
previously requested changes
Mar 24, 2025
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
769fa30
to
e70a65e
Compare
kpfleming
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes AssemblyScript completely from the CLI.
This is considered a breaking change because it means users with a pre-existing project would no longer be able to build their projects. They could use the "other" language option in the fastly.toml to build but it's still introducing an unexpected friction that should be marked with a clear major version boundary.