8000 feat(accesskeys): add support for access keys by anthony-gomez-fastly · Pull Request #1428 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(accesskeys): add support for access keys #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

feat(accesskeys): add support for access keys #1428

merged 3 commits into from
Mar 6, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor
@anthony-gomez-fastly anthony-gomez-fastly commented Mar 5, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users will be able to manage their access keys through the cli

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-object-storage branch 9 times, most recently from 90f8041 to 029ad70 Compare March 6, 2025 16:24
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review March 6, 2025 16:42
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner March 6, 2025 16:42
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-object-storage branch from 029ad70 to 2e277a4 Compare March 6, 2025 16:55
philippschulte
philippschulte previously requested changes Mar 6, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just some nit picks and linting checks you need to address.

kpfleming
kpfleming previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor
@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed look great. There are two linter checks showing up here that probably don't show up locally, but they are easy fixes.

@anthony-gomez-fastly anthony-gomez-fastly merged commit 930b05e into main Mar 6, 2025
11 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1006-object-storage branch March 6, 2025 22:01
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@philippschulte philippschulte Awaiting requested review from philippschulte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-gomez-fastly @kpfleming @philippschulte
0