Additional checking for wasm32-wasi output from Rust projects. #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 11.0.0 a test was added to ensure that the CLI's global configuration file was not configured for 'wasm32-wasi' output from Rust projects. That was insufficient to avoid build errors in existing projects configured for that target, so this commit adds an additional check. Specifically, if the WASM binary is not found in the expected location after a successful build, a check is made to see if the binary is found in the 'old' location. If it is found there, an error is emitted which includes a link to the instructions for how to reconfigure the project.
|
I'm going to recreate this PR as GitHub hasn't processed the last push yet, and it's been 12 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 11.0.0 a test was added to ensure that the CLI's global configuration file was not configured for 'wasm32-wasi' output from Rust projects. That was insufficient to avoid build errors in existing projects configured for that target, so this commit adds an additional check. Specifically, if the WASM binary is not found in the expected location after a successful build, a check is made to see if the binary is found in the 'old' location. If it is found there, an error is emitted which includes a link to the instructions for how to reconfigure the project.
NOTE: The URL in this PR is not yet live; it will be once a PR to our documentation site has been merged.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Are there any considerations that need to be addressed for release?