8000 Increase max config store value length by awilliams-fastly · Pull Request #1485 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Increase max config store value length #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service a 10000 nd privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

Increase max config store value length #1485

merged 4 commits into from
Jun 3, 2025

Conversation

awilliams-fastly
Copy link
Collaborator
@awilliams-fastly awilliams-fastly commented May 29, 2025 •
edited
Loading

The maximum allowed length for a config store entry's value is now configurable. The default is still 8k characters, but may be larger. This increases the limit in the CLI to 64k. If a user attempts to create an entry larger than their allowed limit, the API will return an error. 64k was chosen as a limit to prevent reading from a never-ending input stream.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users with a limit larger than 8k will be able to create config store entries larger than 8k.

Are there any considerations that need to be addressed for release?

@awilliams-fastly
Increase max config store value length
f61bb79 
The maximum allowed length for a config store entry's value is now
configurable. The default is still 8k characters, but may be larger.
This increases the limit in the CLI to 64k. If a user attempts to create
an entry larger than their allowed limit, the API will return an error.
@awilliams-fastly awilliams-fastly requested a review from a team as a code owner May 29, 2025 20:04
kpfleming
kpfleming reviewed May 29, 2025
View reviewed changes
@awilliams-fastly awilliams-fastly merged commit 7eeb8ca into main Jun 3, 2025
12 checks passed
@awilliams-fastly awilliams-fastly deleted the awilliams/cs-limit branch June 3, 2025 16:15
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awilliams-fastly @kpfleming
0