8000 feat(domain discovery): add support for Domain Discovery commands by FarhanSajid1 · Pull Request #1482 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(domain discovery): add support for Domain Discovery commands #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 9, 2025
Merged

feat(domain discovery): add support for Domain Discovery commands #1482

merged 22 commits into from
Jun 9, 2025

Conversation

FarhanSajid1
Copy link
Contributor
@FarhanSajid1 FarhanSajid1 commented May 21, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

This PR adds commands for tools and a domain subcommand. The tools command will be used for placing tools moving forward.

Once a user has enabled Domain Discovery on their accounts, they should have access to the Domain Discovery endpoints.

The commands make use of the status and suggest implementation which were added in fastly/go-fastly#672.

The core changes:

  • Add a root command for tools, which can be reused
  • Add a subcommand for domains, which will be a child of tools.
  • Add suggest and status subcommands under tools
  • Tests for suggest and status subcommands

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users that have enabled domain discovery on their accounts can use the suggest and status commands.

Usage:

Fastly Tools

fastly tools --help
USAGE
  fastly tools <command> [<args> ...]

Tools for working with the Fastly platform

Fastly Domain Tools

fastly tools domain --help
USAGE
  fastly tools domain <command> [<args> ...]

Domain Discovery API tools

Status Usage:

fastly tools domain status --help
USAGE
  fastly tools domain status [<flags>] <domain>

Status Commands

Check domain name availability

fastly tools domain status fastly-testing.org --scope=estimate
fastly tools domain status

Suggest Usage:

fastly tools domain suggest --help
USAGE
  fastly tools domain suggest [<flags>] <query> ...

Returns domain search results for a given query

Suggest Commands

fastly domain-v1 tools suggest apple
fastly tools domain suggest --keywords food,kitchen --defaults=club who what

Are there any considerations that need to be addressed for release?

No breaking changes

@FarhanSajid1 FarhanSajid1 requested a review from Integralist May 21, 2025 16:13
@FarhanSajid1 FarhanSajid1 changed the title Farhansajid1/domain tools feat(domain discovery): add support for Domain Discovery commands May 21, 2025
@FarhanSajid1 FarhanSajid1 marked this pull request as ready for review May 21, 2025 18:48
@FarhanSajid1 FarhanSajid1 requested a review from a team as a code owner May 21, 2025 18:48
@FarhanSajid1 FarhanSajid1 requested a review from kpfleming May 21, 2025 18:48
Integralist
Integralist approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator
@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @FarhanSajid1

Just a couple of minor/nit comments and suggestions (approving to unblock).

< 10000 div id="pullrequestreview-2876144464" class="js-comment js-updatable-content js-socket-channel js-targetable-element js-minimize-container" data-gid="PRR_kwDODjSHn86rbntQ" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0X3JldmlldzoyODc2MTQ0NDY0IiwidCI6MTc1MTY0MzY5Mn0=--d76af374f8669fd2c91e6efa991c2eeb1e7c6a53c7821045e3511a57bf281f4a" data-url="/fastly/cli/pull/1482/partials/reviews/2876144464" >
cee-dub
cee-dub reviewed May 29, 2025
View reviewed changes
kpfleming
kpfleming approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor
@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes, otherwise this looks great! Nice work.

@case-fastly @kpfleming
Domain Discovery -> tools/domain
287aa93 
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
@kpfleming kpfleming enabled auto-merge (squash) June 9, 2025 14:44
@kpfleming kpfleming merged commit ed660ea into main Jun 9, 2025
12 checks passed
@kpfleming kpfleming deleted the farhansajid1/domain-tools branch June 9, 2025 14:58
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-dub cee-dub cee-dub left review comments

@Integralist Integralist Integralist approved these changes

@kpfleming kpfleming kpfleming approved these changes

@case-fastly case-fastly Awaiting requested review from case-fastly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FarhanSajid1 @cee-dub @Integralist @kpfleming @case-fastly
0