8000 feat(domains): adds description field to domainv1 by nsmethwick-fastly · Pull Request #1483 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(domains): adds description field to domainv1 #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

feat(domains): adds description field to domainv1 #1483

merged 2 commits into from
Jun 11, 2025

Conversation

nsmethwick-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users will see the recently added description field for domainv1 endpoints

Are there any considerations that need to be addressed for release?

No breaking changes

@nsmethwick-fastly nsmethwick-fastly requested a review from a team as a code owner May 27, 2025 14:20
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor
@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kpfleming any thoughts?

@kpfleming
Copy link
Contributor

LGTM

@anthony-gomez-fastly anthony-gomez-fastly merged commit 7f9e042 into main Jun 11, 2025
12 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the noah/appeng-10225 branch June 11, 2025 16:12
@kpfleming
Copy link
Contributor

The CHANGELOG entry for this PR was placed in the wrong section, but that can be fixed during release preparation.

@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nsmethwick-fastly @kpfleming @Integralist @anthony-gomez-fastly
0