8000 [CDTOOL-1070] feat(logging): Add support for 'processing region' attribute. by kpfleming · Pull Request #1491 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CDTOOL-1070] feat(logging): Add support for 'processing region' attribute. #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2025
Merged

[CDTOOL-1070] feat(logging): Add support for 'processing region' attribute. #1491

merged 4 commits into from
Jun 11, 2025

Conversation

kpfleming
Copy link
Contributor

All logging commands (create/describe/list/update) now support the 'processing region' attribute.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Are there any considerations that need to be addressed for release?

kpfleming and others added 3 commits June 11, 2025 12:01
@kpfleming
feat(logging): Add support for 'processing region' attribute.
4057754 
All logging commands (create/describe/list/update) now support the
'processing region' attribute.
Update CHANGELOG entry with PR number.
704a423
@kpfleming
Merge branch 'main' into cdtool-1070
e76e6ff
@kpfleming kpfleming marked this pull request as ready for review June 11, 2025 16:04
@kpfleming kpfleming requested a review from a team as a code owner June 11, 2025 16:04
@kpfleming kpfleming requested a review from philippschulte June 11, 2025 16:04
philippschulte
philippschulte approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kpfleming kpfleming enabled auto-merge (squash) June 11, 2025 17:22
@kpfleming kpfleming merged commit 4c0b1d7 into fastly:main Jun 11, 2025
8 checks passed
@kpfleming kpfleming deleted the cdtool-1070 branch June 11, 2025 17:34
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfleming @philippschulte
0