8000 Update Go-Fastly dependency to v3.0.0 by Integralist · Pull Request #193 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Go-Fastly dependency to v3.0.0 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2021
Merged

Update Go-Fastly dependency to v3.0.0 #193

merged 6 commits into from
Jan 20, 2021

Conversation

Integralist
Copy link
Collaborator

Bump the Go-Fastly dependency from 2.x.x to the latest 3.0.0 release.

@Integralist Integralist requested review from phamann, jaredmorrow and a team January 20, 2021 12:21
@Integralist Integralist added the enhancement New feature or request label Jan 20, 2021
@Integralist Integralist force-pushed the integralist/20210120_gofastly_v3 branch from 84d2e69 to d286cf6 Compare January 20, 2021 12:28
phamann
phamann approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member
@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

christophermancini
christophermancini approved these changes Jan 20, 2021
View reviewed changes
Copy link
@christophermancini christophermancini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I don't know the code that well yet.

@Integralist
Copy link
Collaborator Author

Thanks everyone. You probably all did this already but I should have suggested y'all review the individual commits, as the diff tab/view will be 99% copy/paste fix of the import path 😬

@Integralist
Copy link
Collaborator Author

Just to confirm for anyone unaware of the internal discussion:

I intend to merge this PR now it's approved but I won't 'cut a release' until we have #192 updated to pull this PRs changes and itself be reviewed/approved/merged. Then I'll cut a new v0.23.0 minor release.

@Integralist Integralist merged commit a92a9e7 into master Jan 20, 2021
@Integralist Integralist deleted the integralist/20210120_gofastly_v3 branch January 20, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

@christophermancini christophermancini christophermancini approved these changes

@triblondon triblondon triblondon approved these changes

@jaredmorrow jaredmorrow Awaiting requested review from jaredmorrow

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Integralist @phamann @christophermancini @triblondon
0