8000 Remove flaky test logic. by Integralist · Pull Request #249 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove flaky test logic. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

Remove flaky test logic. #249

merged 2 commits into from
Apr 13, 2021

Conversation

Integralist
Copy link
Collaborator

Problem: We added logic recently to prepend a specification URL to the fastly.toml manifest which introduced a flaky test.
Solution: Remove the flaky test logic.
Notes: We have a separate test to validate the prepending logic, so this just means I'm not over complicating an existing set of tests.

@Integralist Integralist added the bug Something isn't working label Apr 13, 2021
@Integralist Integralist requested review from a team and triblondon and removed request for a team April 13, 2021 09:10
@Integralist Integralist merged commit 099ef09 into master Apr 13, 2021
@Integralist Integralist deleted the integralist/20210413_flaky_test branch April 13, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triblondon triblondon triblondon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @triblondon
0