Support usage of IAM role in S3 and Kinesis logging endpoints #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to specify an IAM role for the S3 and Kinesis logging endpoints.
kellymclaughlin
commented
Apr 13, 2021
| input.AccessKey = c.AccessKey | ||
| input.SecretKey = c.SecretKey | ||
|
|
||
| // The following block checks for invalid permutations of the ways in |
There was a problem hiding this comment.
I was looking for something akin to the ArgGroup feature in the clap library for rust, but I didn't see anything similar present in kingpin so I just implemented the checks manually here. If this ever became a more common pattern we could try to add it into the kingpin library or just our fork of it since it's unmaintained because it'd be a lot nicer to have it handled inside the library versus a bunch of ad hoc enforcement in random places in our code.
There was a problem hiding this comment.
Agreed, if this becomes more common then we can think about implementing it within the Fastly Kingpin fork.
Integralist
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify an IAM role for the S3 and Kinesis logging endpoints. Follows from fastly/go-fastly#269.