8000 pkg/compute/pack: implement pack subcommand by Integralist · Pull Request #282 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pkg/compute/pack: implement pack subcommand #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 19, 2021
Merged

pkg/compute/pack: implement pack subcommand #282

merged 15 commits into from
May 19, 2021

Conversation

Integralist
Copy link
Collaborator
@Integralist Integralist commented May 13, 2021 •
edited
Loading

Problem: We want users to experiment with the C@E platform, which means being able to deploy their own WASM binaries compiled using languages not officially supported (yet).

Solution: Implement fastly compute pack, which will accept a --path to a WASM binary and will scaffold the required structure so that fastly compute deploy will know what to do.

Notes: I've also updated fastly compute init to provide a new language option of "other" as this means we can piggyback off the existing logic to build a compatible fastly.toml manifest (which fastly compute deploy will require).

Example

Start by initialising a new project (notice the messaging has changed to reflect the third option "other" being selected):

$ fastly compute init
Creating a new Compute@Edge project.

Press ^C at any time to quit.

Name: [testing-cli-packaging]
Description:
Author:
Language:
[1] Rust
[2] AssemblyScript (beta)
[3] Other (pre-compiled WASM binary)
Choose option: [1] 3

Initialized project testing-cli-packaging to:
        /Users/integralist/Code/go/testing-cli-packaging

To package a pre-compiled WASM binary for deployment, run:
        fastly compute pack

To deploy the package, run:
        fastly compute deploy

To learn about deploying Compute@Edge projects using third-party orchestration tools, visit:
        https://developer.fastly.com/learning/integrations/orchestration/

SUCCESS: Initialized project testing-cli-packaging

The only thing produced by the above subcommand run, was a valid fastly.toml.

Next, package up your pre-compiled WASM binary (in this case I reference a rust C@E starter kit I had built previously from another project):

$ fastly compute pack --path ../some/path/to/a/main.wasm && tree
✓ Initializing...
✓ Copying wasm binary...
✓ Copying manifest...
✓ Creating .tar.gz file...
.
├── fastly.toml
└── pkg
    ├── testing-cli-packaging
    │   ├── bin
    │   │   └── main.wasm
    │   └── fastly.toml
    └── testing-cli-packaging.tar.gz

3 directories, 4 files

Finally, we'll deploy this:

$ fastly compute deploy
There is no Fastly service associated with this package. To connect to an existing service
add the Service ID to the fastly.toml file, otherwise follow the prompts to create a
service now.

Press ^C at any time to quit.

Domain: [gratefully-inspired-ewe.edgecompute.app]
Backend (originless, hostname or IP address): [originless]

✓ Initializing...
✓ Creating service...
✓ Creating domain...
✓ Creating backend...
✓ Uploading package...
✓ Activating version...

Manage this service at:
        https://manage.fastly.com/configure/services/2MJOTguHXRzr7OLcnRxGTU

View this service at:
        https://gratefully-inspired-ewe.edgecompute.app

SUCCESS: Deployed package (service 2MJOTguHXRzr7OLcnRxGTU, version 1)

Fixes #174

@Integralist Integralist added the enhancement New feature or request label May 13, 2021
kailan
kailan reviewed May 13, 2021
View reviewed changes
@Integralist Integralist force-pushed the integralist/compute-pack branch from 2b25acd to 0ed780d Compare May 17, 2021 12:39
@Integralist Integralist mentioned this pull request May 17, 2021
Closed
@Integralist Integralist force-pushed the integralist/compute-pack branch from 90b56dd to 602ad7d Compare May 17, 2021 14:43
@Integralist Integralist marked this pull request as ready for review May 17, 2021 15:29
@Integralist Integralist requested a review from phamann May 17, 2021 15:29
@Integralist
Copy link
Collaborator Author

@phamann I appreciate you're busy so are you happy for someone else to review this? e.g. @fgsch

triblondon
triblondon reviewed May 19, 2021
View reviewed changes
@triblondon
Copy link
Contributor

"Initialized package" => "Initialized project" ?

@fgsch
Copy link
Member
fgsch commented May 19, 2021

Would be possible to use a smaller binary?

@Integralist
Copy link
Collaborator Author

Would be possible to use a smaller binary?

I had used the binary compiled using https://github.com/fastly/compute-starter-kit-rust-default as I was not familiar with generating a WASM binary myself.

But I've managed to replace the main.wasm binary with a plain text file as a real binary isn't necessary for validating the tests.

fgsch
fgsch reviewed May 19, 2021
View reviewed changes
fgsch
fgsch reviewed May 19, 2021
View reviewed changes
fgsch
fgsch reviewed May 19, 2021
View reviewed changes
fgsch
fgsch approved these changes May 19, 2021
View reviewed changes
Copy link
Member
@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested "compute pack" deploying an existing service using an unsupported language, a supported language (rust) and also initialising a project using "Other".

Code looks and works as advertised ✔️

@fgsch
Copy link
Member
fgsch commented May 19, 2021

Left a few non blocking comments but looks great to me.

Thank you for working on this!

phamann
phamann requested changes May 19, 2021
View reviewed changes
Copy link
Member
@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - have requested some changes:

  1. Question regarding an important change in terminology that has wider implications than just the CLI. Therefore, I suggest we revert for the time being,
  2. Nitty ask to use the correct Wasm instead of WASM.

@Integralist Integralist requested a review from phamann May 19, 2021 14:33
phamann
phamann approved these changes May 19, 2021
View reviewed changes
Copy link
Member
@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Integralist Integralist force-pushed the integralist/compute-pack branch from 3e54575 to 84aee19 Compare May 19, 2021 14:44
@Integralist Integralist merged commit 0e65094 into main May 19, 2021
@Integralist Integralist deleted the integralist/compute-pack branch May 19, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triblondon triblondon triblondon left review comments

@kailan kailan kailan left review comments

@phamann phamann phamann approved these changes

@fgsch fgsch fgsch approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4641 No milestone
Development

Successfully merging this pull request may close these issues.

Support alternative languages / precompiled modules
5 participants
@Integralist @triblondon @fgsch @phamann @kailan
0