8000 Test clean-up and modifications to support better consistency by Integralist · Pull Request #327 · fastly/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ cli Public < 8000 /div>

Test clean-up and modifications to support better consistency #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Jul 2, 2021
Merged

Test clean-up and modifications to support better consistency #327

merged 48 commits into from
Jul 2, 2021

Conversation

Integralist
Copy link
Collaborator
@Integralist Integralist commented Jul 2, 2021 •
edited
Loading

Summary
There’s not 4k+ additions (I've split a large test file up into separate files).
There's no ‘business logic’ changes (all code changes are to the test code).
The testutil abstractions listed below (except for NewEnv) already exist in the code base (they're just being applied globally).

Highlights

  • Split the compute tests into separate files (e.g. compute_init_test.go, compute_build_test.go etc).
  • Replaced compute.ManifestFilename with pre-existing manifest.Filename.
  • Utilise testutil.TestScenario wherever possible.
  • Utilise testutil.Args everywhere.
  • Utilise testutil.NewAppRunArgs everywhere.
  • Utilise testutil.NewEnv everywhere.
  • Utilise testutil.Err everywhere.
  • Renamed testutil.ErrAPI to testutil.Err so it could be used more generally.
  • Renamed some variables for clarity (e.g. fpath became configPath, and buf became stdout).

Integralist added 30 commits June 30, 2021 16:06
@Integralist
move tests around
bd8dc25
@Integralist
rename TestAPI to be more generic
a79a254
@Integralist
use testutil.Err in compute tests
2d9a671
@Integralist
fix tests
4e601e4
@Integralist
edgedict to use existing abstraction
115559c
@Integralist
edgedictitem to use existing abstraction
27ced19
@Integralist
healthcheck to use existing abstraction
5b91597
@Integralist
ip to use existing abstraction
7a17018
@Integralist
domain to use existing abstraction
21ddf29
@Integralist
backend to use existing abstraction
8ed2126
@Integralist
pop to use existing abstraction
8e8ca29
@Integralist
version to use existing abstraction
2af5530
@Integralist
service to use existing abstraction
89fa683
@Integralist
serviceversion to use existing abstraction
9dabd82
@Integralist
stats to use existing abstraction
3a971eb
@Integralist
app to use existing abstraction
8369a3a
@Integralist
rename buf to stdout
385818b
@Integralist
logging to use existing abstraction
9a13278
@Integralist
fix compute build tests to use new abstraction
1c5e854
@Integralist
fix deploy tests to use existing abstraction
b7fee8f
@Integralist
fix init tests to use existing abstraction
032ad3e
@Integralist
fix pack tests to use existing abstraction
48342ed
@Integralist
fix publish tests to use existing abstraction
49b0f44
@Integralist
fix update tests to use existing abstraction
7b2e5a8
@Integralist
fix validate tests to use existing abstraction
519722e
@Integralist
fix configure tests to use existing abstraction
1e1fc0a
@Integralist
fix whoami tests to use existing abstraction
5642f4b
@Integralist
change buf to stdout
3ff7288
@Integralist
api mock isn't needed for constructor
02f1489
10000
@Integralist
keep shared mocks together
454fa57
Integralist added 18 commits July 1, 2021 15:33
@Integralist
ensure all tests use new args abstraction
cd154f1
@Integralist
create new environment abstraction
e9aad55
@Integralist
switch pack test to new env abstraction
0f7d39c
@Integralist
switch config test to new env abstraction
bcedb55
@Integralist
switch service test to new env abstraction
e50215f
@Integralist
switch compute unit test to new env abstraction
ba7bd18
@Integralist
don't try to write content to disk if data given is empty
7966e45
@Integralist
switch compute validate test to new env abstraction
1c9df8c
@Integralist
switch compute update test to new env abstraction
0b62869
@Integralist
switch compute publish test to new env abstraction
3c6df26
@Integralist
switch compute init test to new env abstraction
aa18e09
@Integralist
switch compute deploy test to new env abstraction
c5f20ea
@Integralist
switch compute assemblyscript test to new env abstraction
a9e991f
@Integralist
switch compute rust test to new env abstraction
ee656a1
@Integralist
ensure consistent doc string
7d6b8a5
@Integralist
remove use of compute.ManifestFilename in favour of existing manifest…
e09303e 
….Filename
@Integralist
use TestScenario abstraction
ed18d76
@Integralist
clarify the mock test file
b711043
@Integralist Integralist requested a review from triblondon July 2, 2021 08:57
triblondon
triblondon approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor
@triblondon triblondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on a zoom.

@Integralist Integralist merged commit e429d88 into main Jul 2, 2021
@Integralist Integralist deleted the integralist/ci-tests-timeouts branch July 2, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triblondon triblondon triblondon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @triblondon
0