8000 feat(fastly/objectstorage): adds crud operations for access keys in object storage by anthony-gomez-fastly · Pull Request #612 · fastly/go-fastly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(fastly/objectstorage): adds crud operations for access keys in object storage #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2025
Merged

feat(fastly/objectstorage): adds crud operations for access keys in object storage #612

merged 4 commits into from
Feb 21, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?
    Users will be able to use the CRUD functions for Access Keys in Object Storage

Are there any considerations that need to be addressed for release?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-add-object-storage-functions branch from 951fe2d to d78f170 Compare February 20, 2025 19:58
anthony-gomez-fastly
anthony-gomez-fastly commented Feb 20, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly commented Feb 20, 2025
View reviewed changes
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-add-object-storage-functions branch 2 times, most recently from dce8f75 to 8e159b9 Compare February 20, 2025 20:17
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-add-object-storage-functions branch from 8e159b9 to 9e8cbcd Compare February 20, 2025 20:19
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review February 20, 2025 20:19
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1006-add-object-storage-functions branch from 9e8cbcd to 207f799 Compare February 20, 2025 20:32
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner February 20, 2025 20:32
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte reviewed Feb 21, 2025
View reviewed changes
philippschulte
philippschulte previously requested changes Feb 21, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just some nit picks. Please ask Kevin if he is happy with the package structure. This makes sense to me but maybe we don't need the nested structure because there won't be any more APIs related to Fastly object storage.

philippschulte
philippschulte previously requested changes Feb 21, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed one thing. Otherwise this looks great! Kevin also agreed on the package structure: objectstorage.accesskeys.....

philippschulte
philippschulte approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly merged commit d2b45a1 into main Feb 21, 2025
8 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1006-add-object-storage-functions branch February 21, 2025 21:42
@kpfleming kpfleming mentioned this pull request Mar 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

@kpfleming kpfleming Awaiting requested review from kpfleming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte
0