8000 Add support for all documented KV Store API features. by kpfleming · Pull Request #630 · fastly/go-fastly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for all documented KV Store API features. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

Add support for all documented KV Store API features. #630

merged 2 commits into from
Mar 5, 2025

Conversation

kpfleming
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change? - all KV Store API functionality is available

Are there any considerations that need to be addressed for release?

Closes #573.

@kpfleming kpfleming marked this pull request as ready for review March 4, 2025 15:48
@kpfleming kpfleming requested a review from a team as a code owner March 4, 2025 15:48
@kpfleming kpfleming requested a review from philippschulte March 4, 2025 15:48
joeshaw
joeshaw reviewed Mar 4, 2025
View reviewed changes
cee-dub
cee-dub reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor
@cee-dub cee-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some general questions.

@kpfleming kpfleming marked this pull request as draft March 5, 2025 14:56
@kpfleming
* Apply review feedback.
99cb21e 
* Add PR link to CHANGELOG.

* Ensure that tests for '412' errors actually receive them.

* Convert all assertions in main kv_store test function to use
  'testify' module.
@kpfleming kpfleming marked this pull request as ready for review March 5, 2025 16:53
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for the test updates!

philippschulte
philippschulte requested changes Mar 5, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We should refactor the entire test suite by using the testify package. We should only update the return values on err.

@kpfleming
Copy link
Contributor Author

Yeah, testify is pretty great :-)

philippschulte
philippschulte approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kpfleming kpfleming merged commit c0ce59a into fastly:main Mar 5, 2025
5 checks passed
@kpfleming kpfleming deleted the issue-573 branch March 5, 2025 20:37
joeshaw
joeshaw reviewed Mar 7, 2025
View reviewed changes
Copy link
Member
@joeshaw joeshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor documentation-related comments below.

kpfleming added a commit to kpfleming/go-fastly that referenced this pull request Mar 10, 2025
@kpfleming
Add documentation for recently-improved KV Store API.
ffd61c5 
As noted in PR fastly#630, the new structure and functions should have
included doc comments, but did not.
@kpfleming kpfleming mentioned this pull request Mar 10, 2025
Merged
2 tasks
kpfleming added a commit that referenced this pull request Mar 10, 2025
@kpfleming
Add documentation for recently-improved KV Store API. (#636)
85c1a67 
As noted in PR #630, the new structure and functions should have
included doc comments, but did not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-dub cee-dub cee-dub left review comments

@joeshaw joeshaw joeshaw left review comments

@philippschulte philippschulte philippschulte approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kvstore, InsertKVStoreKey() does not support if-generation-match
5 participants
@kpfleming @cee-dub @joeshaw @philippschulte @anthony-gomez-fastly
0