8000 BUG-149: Fix compatibilities performance bug by fbuys · Pull Request #150 · fastruby/next_rails · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BUG-149: Fix compatibilities performance bug #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

fbuys
Copy link
@fbuys fbuys commented Apr 10, 2025

Use fetcher instead of new when we use Gem::SpecFetcher

Fixes: #149

Description

Use fetcher instead of new when we use Gem::SpecFetcher
Fixes: #149

Motivation and Context

How Has This Been Tested?

Using time before and after:

  • Before: 42.34s user 1.83s system 97% cpu 45.095 total
  • After: 5.68s user 0.61s system 72% cpu 8.728 total

Using automated tests.

Screenshots:

Using stack prof:

Before After
image image

I will abide by the code of conduct

Copy link
Member
@FionaDL FionaDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbuys this looks good to me!

fbuys added 2 commits April 10, 2025 21:36
Use fetcher instead of new when we use Gem::SpecFetcher

Fixes: fastruby#149
@fbuys fbuys force-pushed the bug/compatibilities branch from f9ff1ed to f1df7f6 Compare April 10, 2025 19:36
@fbuys fbuys merged commit 9f07d27 into fastruby:main Apr 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bundle report compatibility takes a long time to find incompatible gems
2 participants
0