Bring back support of Ruby 2.3, 2.4 and 2.5 #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add support back for older Ruby versions
JuanVqz
reviewed
May 22, 2025
| spec.add_development_dependency "webmock", "3.20.0" | ||
| spec.add_development_dependency "rexml", "3.2.5" # limited on purpose, new versions don't work with old rubies | ||
| spec.add_development_dependency "webmock", "3.16.2" | ||
| spec.add_development_dependency "base64" |
There was a problem hiding this comment.
@torresga why is this gem needed? can you please add a reference?
There was a problem hiding this comment.
@JuanVqz which gem are you referring to specifically? I have this in the description (edited it a bit in case the original description wasn't clear):
- Several months ago,
rexmlwas updated to 3.3.8 . I had to downgrade it from 3.3.8 to 3.2.5, as 3.2.6 and above set Ruby 2.5 as the minimum requirement as seen inrexml’sgemspecruby/rexml@072b02f. - We added Ruby 3.4 support in February: 816e5b6 by updating
webmockto3.20.0.webmockversion3.20.0is incompatible with Ruby versions below 2.5. - To keep support for both Ruby 3.4 and Ruby 2.5 and below, I decided to downgrade
webmockback to its' previous version and addedbase64as a dependency in thegemspecbecause Ruby 3.4 removed thebase64default gem because it became bundled.
There was a problem hiding this comment.
sorry, I missed the explanation for the base64 in the description :S
JuanVqz
reviewed
May 22, 2025
| raise ArgumentError, "Invalid Rails version format. Example: --rails-version=5.0.7" | ||
| end | ||
|
|
||
| if arg.start_with?("--ruby-version") && !arg.match?(/--ruby-version=+\d+(\.\d+)*$/) | ||
| if arg.start_with?("--ruby-version") && !/--ruby-version=+\d+(\.\d+)*$/.match(arg) |
Co-authored-by: Juan Vásquez <juan@ombulabs.com>
This was referenced May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to add back support of Ruby 2.3, 2.4, and 2.5 as requested in #135.
To add back the support for the older Ruby versions, I had to make the following changes:
rexmlwas updated in this commit e50e05a . I had to downgrade it to 3.2.5, as 3.2.6 and above set Ruby 2.5 as the minimum requirement as seen inrexml’sgemspecruby/rexml@072b02f.webmockto3.20.0.webmockversion3.20.0is incompatible with Ruby versions below 2.5. To keep support for both Ruby 3.4 and Ruby 2.5 and below, I decided to downgradewebmockback to its' previous version and addedbase64as a dependency in thegemspec.match?.match?wasn’t added until Ruby 2.4. I replaced those instances withmatch, which is also compatible with Ruby 2.3.Motivation and Context
How Has This Been Tested?
Ruby 2.3 and 2.4 have been added to the CI and the tests pass in all versions.
Screenshots:
I will abide by the code of conduct