[FAI-15921] Add e2e testings for Windows system in CI #131
Conversation
| function getImagePlatform(image: string): string | undefined { | ||
| if (image?.startsWith('farosai')) { | ||
| return 'linux/amd64'; | ||
| export function processDstDataByLine(line: string, cfg: FarosConfig): string { |
There was a problem hiding this comment.
move up to the file. no change
| /** | ||
| * Filter out spec output | ||
| */ | ||
| export function processSpecByLine(line: string): AirbyteSpec | undefined { |
| options: Docker.ContainerCreateOptions, | ||
| outputStream: Writable, | ||
| inputStream?: ReadStream | PassThrough, | ||
| ): Promise<void> { |
There was a problem hiding this comment.
most functions have the same running docker codes. create a function to avoid duplicate codes
| } | ||
| if (stdinStream) { | ||
| (stdinStream as any).destroy(); | ||
| } |
There was a problem hiding this comment.
this is some weird ....stuff.
took me a day to debug what's going on.
what happened was that the CLI hangs even it runs fine without errors. but it just didn't exit at the end. And this only happens on Github Windows runner.
I tested on my own Windows machine and it didn't hang and exited successfully. I wonder if this has to do with Github Windows runner is not using Docker Desktop.
| status: 'SUCCEEDED', | ||
| }, | ||
| }); | ||
| docker.run = jest.fn().mockImplementation((_image, _command, outputStream: Writable, _createOptions) => { |
There was a problem hiding this comment.
instead of using docker.run() to run for check src connection. I updated to use the same docker process as others (docker.createContainer, container start/wait).
This also has to do with some we
1E79
ird Windows behavior that the stdout/stderr is printing some extra texts. I didn't debug anything deeper and just switch to use container.attach to split stdout and stderr. it seems to fix it. ehhhhhhhh
overall, using docker.createContainer and container start/wait is too hard to mock so just rely on integration tests
Co-authored-by: Chris Wu <chris@faros.ai>
Co-authored-by: Chris Wu <chris@faros.ai>
|
Description
Add e2e bash/powershell tests in github ci for Windows.
More info please check DEVELOPER.md testing section
Type of change