8000 Update root Readme to nodejs CLI by jeniii · Pull Request #132 · faros-ai/airbyte-local-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update root Readme to nodejs CLI #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2025
Merged

Update root Readme to nodejs CLI #132

merged 8 commits into from
Apr 17, 2025

Conversation

jeniii
Copy link
Collaborator
@jeniii jeniii commented Apr 16, 2025

Description

Provide description here

  • Move the old cli to its own dir
  • Have the root dir readme to be the nodejs one

@jeniii jeniii changed the title Deprecate Bash airbyte-cli Readme Update root Readme to nodejs CLI Apr 16, 2025
@@ -1,157 +1,406 @@
# Airbyte Local CLI [![CI](https://github.com/faros-ai/airbyte-local-cli/actions/workflows/ci.yaml/badge.svg)](https://github.com/faros-ai/airbyte-local-cli/actions/workflows/ci.yaml)
Copy link
Collaborator Author
@jeniii jeniii Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i move the readme under airbyte-local-cli-nodejs to the root

@jeniii jeniii requested a review from Copilot April 16, 2025 23:07
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jeniii jeniii requested a review from Copilot April 17, 2025 17:05
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the project structure by updating the root README to reflect the new Node.js CLI and moving the old Bash CLI to its own directory. Key changes include:

  • Adding a redirect in the Node.js CLI README.
  • Introducing a deprecation notice and updated instructions in the Bash CLI README.
  • Updating the CI workflow to reference the new working directories for the Bash CLI tests.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

File Description
airbyte-local-cli-nodejs/README.md Adds a single-line redirect to the main README.
airbyte-local-cli-bash/README.md Introduces deprecation messaging and comprehensive usage instructions.
.github/workflows/ci.yaml Adjusts working directory paths for building and testing the Bash CLI.
Files not reviewed (1)
  • sonar-project.properties: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

@jeniii jeniii merged commit b91bd9d into main Apr 17, 2025
14 checks passed
@jeniii jeniii deleted the jg/doc branch April 17, 2025 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0