8000 Use export instead of declare -g by willmarks · Pull Request #106 · faros-ai/faros-events-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use export instead of declare -g #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Use export instead of declare -g #106

merged 2 commits into from
Jun 6, 2023

Conversation

willmarks
Copy link
Collaborator
@willmarks willmarks commented Jun 6, 2023

Closes #105

About

declare -g is not supported by some instances of MacOS. We should use the more general export command to achieve the functionality we need.

@willmarks willmarks requested a review from tovbinm June 6, 2023 16:16
@sonarqubecloud
Copy link
sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@willmarks willmarks merged commit 13089cb into main Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@tovbinm tovbinm deleted the wm/fix branch June 6, 2023 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Faros CLI is broken on macOS
2 participants
0