Fix handling variadic functions #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe3dback
requested changes
Jun 8, 2024
| // unknown injection type, possible generics or other not known | ||
| // go features on current moment | ||
| // we can extend this function later for new cases | ||
| if gate.IsVariadic && len(callExpr.Args) <= gate.Index { |
There was a problem hiding this comment.
It's worth adding a clarifying commentary on what is being tested here and why
| // possible is some not importable std const like `errors` | ||
| // or not known ast at this moment | ||
| continue | ||
| for idx := gate.Index; idx <= maxIdx; idx++ { |
There was a problem hiding this comment.
Oh, thank you, it should be used instead of a gate.Index.
Also, do we actually have a test coverage for this part? Maybe it's worth adding it there.
| @@ -19,6 +19,7 @@ type ( | |||
| ArgumentDefinition Source // where method param type defined (func (a,b,c _int_)) | |||
| Interface Interface // used interface for injection | |||
| Implementations []Implementation // all code links to this param | |||
| IsVariadic bool // function param is variadic | |||
There was a problem hiding this comment.
It would be great to add an example in the comments, like:
IsVariadic bool // function param is variadic (func (a bool, nums ...int))
fe3dback
approved these changes
Jun 12, 2024
|
thx, merged in v1.11.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55