Use ThreadPoolExecutor to parallelize RPM uploads to Pulp. #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request validationFailed🔴 Failed or pending checks - Success🟢 Review - Reviewed by a member |
praiskup
reviewed
May 6, 2025
backend/copr_backend/storage.py
Outdated
| def upload_build_results(self, chroot, results_dir, target_dir_name): | ||
| max_workers = min(32, (os.cpu_count() or 1) * 5) # This could probably be hardcoded |
There was a problem hiding this comment.
This would be min(32, 80) in our case, and we can expect ~100+ processes uploading stuff to Pulp, i.e. 3200 parallel threads.
|
Thank you, @dkliban, awesome contribution! I just think we should limit the concurrency "by default" (parallelize just the migration script). Otherwise looks good. |
|
@praiskup I updated the PR with your suggestions. |
praiskup
reviewed
May 6, 2025
|
Ideally please provide the docstrings (our preferred style), or prefix "internal" methods with |
praiskup
reviewed
May 7, 2025
praiskup
reviewed
May 7, 2025
e6a34e8 to
94f558f
Compare
|
LGTM |
praiskup
approved these changes
May 7, 2025
FrostyX
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.