We should have a way to move selector-part+argument when renaming a method #4476

girba · 2025-04-15T16:43:38Z

When we rename methods, we can move selector parts without the arguments. But sometimes, we want to move both.

One option would be to add extra buttons for moving the whole piece and only show the buttons one hover.
Another option is to handle this using the existing buttons using a modifier primary + click

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1732/src'; load All commits (including upstream repositories) since last build: feenkcom/Bloc@13a3a4 by Juraj Kubelka fix typo feenkcom/Brick@961a47 by Juraj Kubelka add `BrPopoverRelocateReason class>>#cleanUp` [#4513] feenkcom/Brick@737047 by Juraj Kubelka clean relocate reason [#4513] Add `BrPopoverRelocateReason` feenkcom/Brick@b9a506 by Juraj Kubelka Merge e4a7372af4b2a0661df112c1d80519cb54f6163f feenkcom/Brick@bcb9e2 by Juraj Kubelka add `*firstTime: isFirstTimeDisplay` parameter [#4513] feenkcom/Brick@8fb3ec by Juraj Kubelka add `BrPopoverVisibleWidgetBoundsRelocator`and `BrPopoverContainerVisibilityUpdater` [#4513] - add some class comments - make it possible to keep dropdown visible even for anchor widgets outside of the visible area feenkcom/gtoolkit-coder@fc53cc by John Brant Merge 09a3a70737605aaccb5122e03df6731d134f3b10 feenkcom/gtoolkit-coder@437e59 by John Brant [#4476] new rename method controller feenkcom/gtoolkit-coder@09a3a7 by Juraj Kubelka Merge e0fee54cf2bafe8aec9e9b311689f651b52e6dcd feenkcom/gtoolkit-coder@4a1c63 by Juraj Kubelka keep search text dropdown always visible [#4504] feenkcom/gt4pharo@dbbc77 by John Brant Merge 1af179eb01d074370336611c805c83dd233b13e5 feenkcom/gt4pharo@6c46ee by John Brant [#4476] new rename method controller feenkcom/gt4pharo@1af179 by Juraj Kubelka Merge 4c6f996bc19fe9492215f9eeb195d757fa0ca428 feenkcom/gt4pharo@21222a by Juraj Kubelka keep save dropdown always visible [#4513] feenkcom/PharoLink@130879 by Andrei Chis Add an utility method PharoLinkTestCaseAnnouncement>>#identifierDescription feenkcom/gtoolkit-wireencoding@bd5cf1 by Alistair Grant [#4429] Add GtWireMaxDepthEncoder and GtWireMinDepthEncoder to GtWireEncoder. feenkcom/gtoolkit-scenery@344fd7 by Oscar Nierstrasz Working on inspector stencil view (not initializing correctly). #4317 feenkcom/gtoolkit-scenery@a71c78 by Oscar Nierstrasz Refactore inspector stencil to use a dedicated element. #4317 feenkcom/gtoolkit-scenery@8a1bf0 by Oscar Nierstrasz Moved some test examples to a different class. #4317 feenkcom/gt4llm@7544fb by Tudor Girba add GtLlmTutorFormatDescription and GtLlmTutorAction as deprecated feenkcom/gt4llm@dcd9c6 by Tudor Girba add GtLlmTutorActionExample as deprecated feenkcom/gt4llm@0729a6 by Tudor Girba move ollama extensions from tutor to the assistant feenkcom/gt4llm@a5d486 by Tudor Girba Merge c281aa6b254bf8450096cbfd58a7e91584526845 feenkcom/gt4llm@9a4923 by Tudor Girba add a deprecated GtLlmTutor to make extensions loadable feenkcom/gt4llm@c281aa by Tudor Girba fix LLM examples to use Assistant instead of Tutor feenkcom/gt4llm@c527f4 by Veit Heller Rename tutor to assistant [#4510] be7dbb by Veit Heller Rename LLM tutor to assistant [#4510]

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1734/src'; load All commits (including upstream repositories) since last build: feenkcom/gtoolkit-vm-bindings@4d7ac7 by Aliaksei Syrel add accessor for class names feenkcom/gtoolkit-vm-bindings@4b479f by Aliaksei Syrel move some bindings to a different package feenkcom/Brick@9ab593 by Don Roberts Merge branch 'main' of https://github.com/feenkcom/Brick feenkcom/Brick@6114ff by Don Roberts Refactor location of classifiers feenkcom/gtoolkit-coder@4b2fb3 by Don Roberts Merge branch 'main' of https://github.com/feenkcom/gtoolkit-coder feenkcom/gtoolkit-coder@13c27e by Don Roberts Refactor location of classifiers feenkcom/gt4pharo@2cc8a6 by Don Roberts Merge 983a4cc043703a0b8400ac9e025446d517bf5ffc feenkcom/gt4pharo@e3f576 by Don Roberts Move smalltalk word classification out of BrTextEditorModel feenkcom/gt4pharo@983a4c by John Brant Merge 31a212cd11a0e78f9916acafc6b4db1920ea4ab4 feenkcom/gt4pharo@df6cdc by John Brant [#4476] examples for new rename method controller feenkcom/gt4pharo@31a212 by Don Roberts Merge branch 'main' of https://github.com/feenkcom/gt4pharo feenkcom/gt4pharo@597f25 by Don Roberts Refactor location of classifiers feenkcom/gtoolkit-inspector@0f9e38 by John Brant [#4514] forward to #gtSenders when displaying references feenkcom/lepiter@72ab34 by Veit Heller Use page shared binding in bindings action feenkcom/gtoolkit-demos@c9010e by Oscar Nierstrasz Added SPL reduction step scenery to the slide priority list feenkcom/gt4gemstone@af4d3e by Alistair Grant GtRsrProxyServiceClient>>becomeProxyRemoteClass set the gtSession in the new proxy feenkcom/gtoolkit-scenery@6a2022 by Oscar Nierstrasz Added embedded sceneries example.#4317 feenkcom/gtoolkit-scenery@55a11f by Oscar Nierstrasz Added an Example method stencil #4317 feenkcom/gtoolkit-scenery@1ae090 by Oscar Nierstrasz Create a dedicated MethodByName utility to convert method names to methods #4317 feenkcom/gtoolkit-scenery@b8293b by Oscar Nierstrasz Started an example method stencil. #4317 feenkcom/gtoolkit-scenery@9ea21a by Oscar Nierstrasz Cleaning examples. #4317 feenkcom/gtoolkit-scenery@3ed47b by Oscar Nierstrasz Selected inspector views persist when restored. #4317 feenkcom/gtoolkit-scenery@537c97 by Oscar Nierstrasz Fix storeOn: and equality for the inspector stencil. #4317 feenkcom/gtoolkit-scenery@e644e8 by Oscar Nierstrasz Fixed inspector stencil display thanks to TG -- fitContent container must not hold a matchParent child. #4317 feenkcom/gtoolkit-scenery@a36063 by Oscar Nierstrasz Small cleanups. #4317 feenkcom/gt4llm@b5fd08 by Tudor Girba Merge 49de7208f94ecbe389dddde42a93173c3440b5f7 feenkcom/gt4llm@d8b94a by Tudor Girba make the changes view in the wardley message be matchParent feenkcom/gt4llm@49de72 by Veit Heller Remove debug code from response provider

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1736/src'; load All commits (including upstream repositories) since last build: feenkcom/gtoolkit-examples@dade22 by Oscar Nierstrasz Added an examples view for the factory feenkcom/Brick@b40a6e by Don Roberts Move classification into separate package feenkcom/Brick@d29d92 by Don Roberts Revert "Move classifiers to separate package" This reverts commit 874351f60dd76e251da3fba40f4843e0bf56f5c7. feenkcom/Brick@874351 by Don Roberts Move classifiers to separate package feenkcom/gtoolkit-coder@510347 by Don Roberts Move classification into separate package feenkcom/gtoolkit-coder@d7cd29 by Don Roberts Revert "Move classifiers to separate package" This reverts commit 01047a35cd070f6facc86cbca5b91a24176b5258. feenkcom/gtoolkit-coder@01047a by Don Roberts Move classifiers to separate package feenkcom/gt4pharo@2f147c by Don Roberts Move classification into separate package feenkcom/gt4pharo@fdc77b by Don Roberts Revert "Move classifiers to separate package" This reverts commit d349debc40601cbb50ace3b6cdf5dc5e4f26eae2. feenkcom/gt4pharo@116893 by Don Roberts Merge cd3830f13ee2c6bcbbcf43e4d7971ec8db43bb14 feenkcom/gt4pharo@d349de by Don Roberts Move classifiers to separate package feenkcom/gt4pharo@cd3830 by John Brant [#4476] examples for new rename method controller feenkcom/gtoolkit-remote@ab523f by Alistair Grant Add proxy cache (GtProxyCacheStrategy) feenkcom/gtoolkit-scenery@b28e52 by Juraj Kubelka rename `<return: #gtScenery>` to `<return: #GtScenery>` feenkcom/gtoolkit-scenery@f0f2ab by Oscar Nierstrasz Automatically categorize new scenery storage methods as scenery. #4317 feenkcom/gtoolkit-scenery@9d9b37 by Oscar Nierstrasz Added new inspector stencils for slides and scripters. #4317 feenkcom/gtoolkit-scenery@51e7d7 by Oscar Nierstrasz Extended MethodByName; Added EmbeddedSceneryStencil; some refactoring. #4317 feenkcom/gtoolkit-scenery@9bff6e by Oscar Nierstrasz Add a `<storedScenery>` pragma to all generated sceneries. #4317 feenkcom/gt4llm@4472e2 by Veit Heller Merge 3ed9f37f1070530df0b4bd3a90476d1190c0ca87 feenkcom/gt4llm@d9011c by Veit Heller Fix reification for assistant renames

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1741/src'; load All commits (including upstream repositories) since last build: feenkcom/Brick@45aaf8 by Don Roberts Merge a0cf7ac227c2f3655e7f99a35828852a3788e3e7 feenkcom/Brick@efc05e by Don Roberts Make BrCamelCaseWordClassifier also break on underscores [[#4516]] feenkcom/gt4pharo@9103ec by John Brant [#4476] clear highlight in selector rename editors feenkcom/gtoolkit-remote@fb1fcb by Alistair Grant Add #isGtProxyObject feenkcom/gtoolkit-wireencoding@de5382 by Alistair Grant GtWireObjectByNameEncoder guard against attempting to encode proxy objects. feenkcom/gtoolkit-wireencoding@a548df by Alistair Grant GtWireEncoderDecoder add mappings for GspoDictionary, GtpoBehavior, GtpoClass, GtpoModule feenkcom/gtoolkit-wireencoding@ed30ea by Alistair Grant GtWireObjectByNameEncoder guard against attempting to encode proxy objects. feenkcom/gt4gemstone@347ff1 by Alistair Grant Set script x bit feenkcom/gt4gemstone@2ddeeb by Alistair Grant [#4518] Add Class History context menus feenkcom/gtoolkit-scenery@cf82bf by Oscar Nierstrasz Patch for JSON encoding error. GtSceneryTextLabelElement feenkcom/gtoolkit-scenery@520dec by Oscar Nierstrasz Introduce better summary display for stencils, items and connections using a key attribute. GtSceneryTextLabelElement feenkcom/gtoolkit-scenery@bd208b by Oscar Nierstrasz Updated demo sceneries with big headings GtSceneryTextLabelElement feenkcom/gtoolkit-scenery@5cc6d3 by Oscar Nierstrasz Started demo sceneries; added support for text label weight and font size GtSceneryTextLabelElement 1bbf9c by Alistair Grant Delete gem*.log files prior to running gemstone tests

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1751/src'; load All commits (including upstream repositories) since last build: feenkcom/gt4pharo@51cfa5 by John Brant [#4476] changing rename method to use hover attributes

Metacello new baseline: 'GToolkitForPharo9'; repository: 'github://feenkcom/gtoolkit:v1.0.1753/src'; load All commits (including upstream repositories) since last build: feenkcom/gtoolkit-boxer@b82779 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-utility@d46bda by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/pharo-futures@5071fc by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/fenster@45d591 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-examples@b5507c by Oscar Nierstrasz Merge d6bbf2540653a925390b8a3ee4dd883320dde33d feenkcom/gtoolkit-examples@838ab7 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/sparta@30c926 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-glutin@b750db by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/Bloc@c41ab5 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/bloc-pac@f82450 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/Brick@2238f8 by Juraj Kubelka properly display label tooltips [#4522] - set a popover common aptitude - convert key combinations to strings using `#gtDisplayString` feenkcom/Brick@1b18d7 by Juraj Kubelka menu: store focuse owner before popover opening [#4519] feenkcom/Brick@9d763f by Juraj Kubelka Merge branches 'main' and 'main' of github.com:feenkcom/Brick feenkcom/Brick@a49dfc by Juraj Kubelka properly initialize selected item element [#4519] feenkcom/Brick@d79837 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/Brick@120023 by Juraj Kubelka rename method protocols [#4519] feenkcom/Brick@38142a by Juraj Kubelka remove selection from a basic example [#4519] feenkcom/gtoolkit-notifications@4e5580 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-pager@95fc7f by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4magritte@d3ce16 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-coder@27f0ae by Juraj Kubelka wrench fix-it button displays a shortcut in its tooltip [#4522] feenkcom/gtoolkit-coder@fefc06 by Juraj Kubelka Merge branches 'main' and 'main' of github.com:feenkcom/gtoolkit-coder feenkcom/gtoolkit-coder@bf10a0 by Juraj Kubelka make fix-it popover navigable using keyboard [#4522] feenkcom/gtoolkit-coder@8a42d2 by Oscar Nierstrasz Merge 9a9a353d8f3b87c057312d82345691b1151dbb2f feenkcom/gtoolkit-coder@0aa8fb by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-coder@9a9a35 by John Brant changing fix it attribute to fit contents for description feenkcom/gt4pharo@2a534e by John Brant [#4476] enabling new rename method controller feenkcom/gtoolkit-presenter@86f573 by Tudor Girba remove reference to inexistent method feenkcom/gtoolkit-presenter@535a55 by Oscar Nierstrasz Added a scenery slide #4317 feenkcom/gtoolkit-presenter@6d7833 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/filewatcher@cc2002 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-spotter@f5e77e by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-inspector@787d74 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-debugger@af90c1 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-filebrowser@b8bf63 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-external-process@27bce2 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/PythonBridge@44509e by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-remote@3ca094 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-remoterunner@bb49df by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4smacc@66a9d6 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-visualizer@1e8d16 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4json@38d876 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/DeepTraverser@2909a6 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-releaser@cec988 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/lepiter@63b1ef by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4changes@0ad3ca by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4graphql@a14d90 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-constrainer@658da9 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4petitparser2@4c4f6e by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-demos@2c4d39 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/famix3@be1b3d by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4famix3@97c6db by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/iceberg-git-cli@b7f205 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4git@974123 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-world@86997b by Juraj Kubelka magrite descriptions view includes magritte action descriptions feenkcom/gtoolkit-world@e40a71 by Juraj Kubelka Merge 0bf52084a922f686913594516773aa9391e1007c feenkcom/gtoolkit-world@fd78c9 by Juraj Kubelka tool menu: store focuse owner before popover opening [#4519] feenkcom/gtoolkit-world@0bf520 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-wireencoding@a1f36f by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4gemstone@e9be0c by Oscar Nierstrasz Merge 1716c0a077479a30c4d9f4f43e49b2d16077a089 feenkcom/gt4gemstone@59a161 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4jenkins@00d250 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gtoolkit-scenery@142eb1 by Oscar Nierstrasz Added <return:...> pragma to examples. feenkcom/gt4openapi@7db807 by Oscar Nierstrasz Added <return:...> pragma to examples. 30590b by Oscar Nierstrasz Merge f46597f c08f66 by Oscar Nierstrasz Added <return:...> pragma to examples.

seandenigris · 2025-05-27T13:32:35Z

For posterity, skimming the commits it looks like we went with the showing extra buttons on hover option

girba added the enhancement label Apr 15, 2025

girba added this to the v1.0 milestone Apr 15, 2025

girba assigned j-brant Apr 15, 2025

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Apr 25, 2025

[feenkcom/gtoolkit#4476] starting a new rename method controller

4085b92

j-brant added a commit to feenkcom/gtoolkit-coder that referenced this issue Apr 28, 2025

[feenkcom/gtoolkit#4476] new rename method controller

437e59b

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Apr 28, 2025

[feenkcom/gtoolkit#4476] new rename method controller

6c46ee2

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Apr 29, 2025

[feenkcom/gtoolkit#4476] examples for new rename method controller

df6cdc7

j-brant added a commit to feenkcom/gt4pharo that referenced this issue Apr 30, 2025

[feenkcom/gtoolkit#4476] examples for new rename method controller

cd3830f

j-brant added a commit to feenkcom/gt4pharo that referenced this issue May 2, 2025

[feenkcom/gtoolkit#4476] clear highlight in selector rename editors

9103ec9

8000 j-brant added a commit to feenkcom/gt4pharo that referenced this issue May 5, 2025

[feenkcom/gtoolkit#4476] changing rename method to use hover attributes

51cfa56

j-brant added a commit to feenkcom/gt4pharo that referenced this issue May 5, 2025

[feenkcom/gtoolkit#4476] enabling new rename method controller

2a534e4

j-brant closed this as completed May 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

We should have a way to move selector-part+argument when renaming a method #4476

We should have a way to move selector-part+argument when renaming a method #4476

Uh oh!

We should have a way to move selector-part+argument when renaming a method #4476

We should have a way to move selector-part+argument when renaming a method #4476

Comments

Uh oh!