8000 fix(bloc_test): revert mocktail export by felangel · Pull Request #2513 · felangel/bloc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(bloc_test): revert mocktail export #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

fix(bloc_test): revert mocktail export #2513

merged 1 commit into from
Jun 3, 2021

Conversation

felangel
Copy link
Owner
@felangel felangel commented Jun 3, 2021

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package labels Jun 3, 2021
@felangel felangel self-assigned this Jun 3, 2021
@codecov
Copy link
codecov bot commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #2513 (51b54f0) into master (d07ebe5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #2513    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           20         3    -17     
  Lines          538        71   -467     
==========================================
- Hits           538        71   -467
Impacted Files Coverage Δ
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
packages/bloc/lib/src/transition.dart
packages/bloc/lib/src/bloc_observer.dart
packages/bloc/lib/src/bloc.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
...lutter_bloc/lib/src/multi_repository_provider.dart
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart
packages/flutter_bloc/lib/src/bloc_provider.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
...ages/flutter_bloc/lib/src/repository_provider.dart
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d51b65...51b54f0. Read the comment docs.

@felangel felangel merged commit b100787 into master Jun 3, 2021
@felangel felangel deleted the fix/bloc-test-mocktail-export branch June 3, 2021 23:51
@felangel felangel mentioned this pull request Jun 3, 2021
Closed
@samandmoore
Copy link

Aw. I kinda loved this because it forced me and my team to migrate to mocktail. The PR to fix all the issues was hell, but it was worth it!

@felangel
Copy link
Owner Author
felangel commented Jun 4, 2021

Aw. I kinda loved this because it forced me and my team to migrate to mocktail. The PR to fix all the issues was hell, but it was worth it!

Yeah it was just causing many developers problems because of import conflicts 😛

Nomeleel pushed a commit to Nomeleel/bloc that referenced this pull request Jul 23, 2021
@felangel @Nomeleel
fix(bloc_test): revert mocktail export (felangel#2513)
b6a461b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felangel felangel

Labels
bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Info: bloc_test 8.0.1 introduced breaking changes compared to 8.0.0 when importing mockito
2 participants
@felangel @samandmoore
0