8000 docs(flutter_bloc): example improvements by felangel · Pull Request #2878 · felangel/bloc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(flutter_bloc): example improvements #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2021
Merged

docs(flutter_bloc): example improvements #2878

merged 6 commits into from
Oct 14, 2021

Conversation

felangel
Copy link
Owner

Status

READY

Breaking Changes

NO

Description

  • docs(flutter_bloc): example improvements

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added documentation Documentation requested pkg:flutter_bloc This issue is related to the flutter_bloc package labels Oct 14, 2021
@felangel felangel self-assigned this Oct 14, 2021
@codecov
Copy link
codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #2878 (579ef10) into master (e17586a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          172       172           
=========================================
  Hits           172       172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17586a...579ef10. Read the comment docs.

marcossevilla
marcossevilla reviewed Oct 14, 2021
View reviewed changes
marcossevilla
marcossevilla reviewed Oct 14, 2021
View reviewed changes
marcossevilla
marcossevilla reviewed Oct 14, 2021
View reviewed changes
marcossevilla
marcossevilla previously approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator
@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added periods for consistency with the rest of the comments 👍

@felangel @marcossevilla
Update packages/flutter_bloc/example/lib/main.dart
e1714b8 
Co-authored-by: Marcos Sevilla <31174242+marcossevilla@users.noreply.github.com>
@felangel @marcossevilla
Update packages/flutter_bloc/example/lib/main.dart
eed6380 
Co-authored-by: Marcos Sevilla <31174242+marcossevilla@users.noreply.github.com>
felangel
felangel commented Oct 14, 2021
View reviewed changes
felangel and others added 2 commits October 14, 2021 16:41
@felangel @marcossevilla
Apply suggestions from code review
314ccc6 
Co-authored-by: Marcos Sevilla <31174242+marcossevilla@users.noreply.github.com>
@marcossevilla
Update packages/flutter_bloc/example/lib/main.dart
5c7ba5e
marcossevilla
marcos 8000 sevilla previously approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator
@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@felangel felangel merged commit bba16fe into master Oct 14, 2021
@felangel felangel deleted the docs/flutter-bloc-example-improvements branch October 14, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcossevilla marcossevilla marcossevilla left review comments

Assignees

@felangel felangel

Labels
documentation Documentation requested pkg:flutter_bloc This issue is related to the flutter_bloc package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @marcossevilla
0