8000 Fix final time overshoot by RemDelaporteMathurin · Pull Request #556 · festim-dev/FESTIM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix final time overshoot #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix final time overshoot #556

merged 2 commits into from
Jul 26, 2023

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This is a patch to ensure the time doesn't over shoot the simulation final time.
Turns out #542 fixed the tiny stepsize issue but introduced an overshoot.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link
codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d5fbe59) 98.82% compared to head (de417dc) 98.82%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          55       55           
  Lines        2038     2038           
=======================================
  Hits         2014     2014           
  Misses         24       24
Impacted Files Coverage Δ
festim/generic_simulation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jhdark
jhdark approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator
@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RemDelaporteMathurin RemDelaporteMathurin merged commit 7d4307b into main Jul 26, 2023
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix-final-time-overshoot branch July 26, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdark jhdark jhdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemDelaporteMathurin @jhdark
0