8000 Remove demos from repo by jhdark · Pull Request #558 · festim-dev/FESTIM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove demos from repo #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

jhdark
Copy link
Collaborator
@jhdark jhdark commented Jul 27, 2023

Proposed changes

With the FESTIM-workshop in a much better state and the festim pip package, think its time to say goodbye to the demos. The workflow item is also removed which should help with PR testing workflow time slightly.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7d4307b) 98.82% compared to head (790affe) 98.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          55       55           
  Lines        2038     2038           
=======================================
  Hits         2014     2014           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit dc07375 into festim-dev:main Jul 27, 2023
@jhdark jhdark deleted the remove_demos branch October 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0