8000 Steady state by RemDelaporteMathurin · Pull Request #642 · festim-dev/FESTIM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Steady state #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Steady state #642

merged 2 commits into from
Nov 15, 2023

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This small PR adds support for steady state calculations

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cea216) 98.33% compared to head (1eecb9d) 98.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #642      +/-   ##
===========================================
+ Coverage    98.33%   98.34%   +0.01%     
===========================================
  Files           20       20              
  Lines          903      909       +6     
===========================================
+ Hits           888      894       +6     
  Misses          15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator
@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just need to sort out some conflicts by look of it

@RemDelaporteMathurin RemDelaporteMathurin merged commit 4130f3a into fenicsx Nov 15, 2023
@RemDelaporteMathurin RemDelaporteMathurin deleted the steady-state branch November 15, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0