8000 Radioactive decay in Theory by RemDelaporteMathurin · Pull Request #816 · festim-dev/FESTIM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Radioactive decay in Theory #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

Radioactive decay in Theory #816

merged 3 commits into from
Jul 23, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Fixes #785

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

@RemDelaporteMathurin RemDelaporteMathurin added this to the v1.3 milestone Jul 23, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (84e7861) to head (54603e7).
Report is 111 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          61       61           
  Lines        2707     2707           
=======================================
  Hits         2695     2695           
  Misses         12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KulaginVladimir
KulaginVladimir requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator
@KulaginVladimir KulaginVladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair good PR. One major comment concerns the units. We discussed earlier that it might be beneficial to also add the units in the theory section.

RemDelaporteMathurin and others added 2 commits July 23, 2024 21:31
@RemDelaporteMathurin @KulaginVladimir
Add units
48beb5c 
Co-authored-by: Vladimir Kulagin <59147151+KulaginVladimir@users.noreply.github.com>
@RemDelaporteMathurin
rewording
54603e7
@RemDelaporteMathurin RemDelaporteMathurin merged commit 33e4e42 into main Jul 23, 2024
8 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the decay-docs branch August 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulaginVladimir KulaginVladimir KulaginVladimir approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Documentation" add formulation and theory of radioactive decay
2 participants
@RemDelaporteMathurin @KulaginVladimir
0