Fixed 8000 bloat, fixed some minor issues and added a bunch of comments #1
Conversation
|
thank you for this pr! what about making your repository named as |
|
I removed many of the C++ standard libraries because C++ standard libraries are pretty bloated, especially compared to their C counterparts. They were a lot simpler to implement. I removed some of the C++ features you used because most of them weren't severing much of a purpose. For example the code is essentially the same thing with the class as it was without it. So there wasn't much reason to have a class. Maybe you could replace the class with a namespace instead? Abstraction is almost never free. Most abstraction (such as the use of objects) come with some performance drop especially. Making it important to use the best tool for the job rather than the flashiest. |
|
Also, at the first least I'd suggest checking out some of the other changes I made for example changing unsigned char* arr = new unsigned char[width * height * 3];which allocates memory from RAM when you don't really need to. Plus allocating memory from RAM takes more time than just using stack memory. into unsigned char arr[width * height * 3];
(and removing delete[] arr)which just uses memory from the stack |
Added a bunch of comments commenting on changes that should be bad [I don't really wanna make many fundamental changes].
But I also removed a lot of the bloat included (including a lot of the c++ standard library), some of the ugly code (from the std library, almost none of yours).
And did some other minor fixes.
I also completely removed the xss_main class and header as they're not required really.
Some suggestions for changing it are included.