8000 Replace tags from variables by wu3rstle · Pull Request #159 · feulf/raintpl3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace tags from variables #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2014
Merged

Replace tags from variables #159

merged 1 commit into from
Oct 15, 2014

Conversation

wu3rstle
Copy link
Contributor

Please add supporting path replacement for variables in templates.

Replace tags from variables
dbec101 
Please add supporting path replacement for variables in templates.
@feulf
Copy link
Owner
feulf commented Oct 15, 2014

Have you run a few tests? I think running path_replace after everything is rendered should be fine, but I just want to make sure that this won't break anything.

Thanks.

@wu3rstle
Copy link
Contributor Author

If i have a variable in my template e.g.:

<img src="{$image1}">

where image1 is 350x150.gif

With beforeParse i'll get the following error:

"Parse error: syntax error, unexpected '}' in APP_DIR\cache\preview.4974a9679af090f169163958738cbfdf.rtpl.php on line 2"

With afterParse everything looks fine.

@feulf
Copy link
Owner
feulf commented Oct 15, 2014

I think that's how it should work so I'm going to merge your change. Thanks!

On Wed, Oct 15, 2014 at 2:16 PM, Tobias Negd notifications@github.com
wrote:

If i have a variable in my template e.g.:

where image1 is 350x150.gif

With beforeParse i'll get the following error:

"Parse error: syntax error, unexpected '}' in
APP_DIR\cache\preview.4974a9679af090f169163958738cbfdf.rtpl.php on line 2"

With afterParse everything looks fine.

—
Reply to this email directly or view it on GitHub
#159 (comment).

feulf added a commit that referenced this pull request Oct 15, 2014
@feulf
Merge pull request #159 from ct4n/patch-2
cb87edf 
path_replace run on after_filter instead of before_filter
@feulf feulf merged commit cb87edf into feulf:master Oct 15, 2014
@feulf
Copy link
Owner
feulf commented Oct 15, 2014

Thanks @ct4n

@wu3rstle wu3rstle deleted the patch-2 branch October 15, 2014 18:56
@wu3rstle wu3rstle mentioned this pull request Oct 19, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wu3rstle @feulf
0