Update the Rakefile to not generate a gemspec #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@technicalpickles |
It no longer uses jeweler, so shouldn't need to be regenerating the file. Best practice is to have `git ls-files` in the gemspec itself. It will be evaluated at the time that the gem is built, and an expanded version of the gemspec is included in the gem. This changes the Rakefile to remove the gemspec task, and move the logic for determining files into the gemspec. Some other changes related: - remove check for VERSION file, since no longer using jeweler - use `gem build` with `--output` to not require mving it after it's built - add `-Ilib` to `reference` task, otherwise it fails to find ffaker
4fbebac to
f35bcc2
Compare
|
@marocchino I've rebased, and you should already have access to make edits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It no longer uses jeweler, so shouldn't need to be regenerating the file.
Best practice is to have
git ls-filesin the gemspec itself. It willbe evaluated at the time that the gem is built, and an expanded version
of the gemspec is included in the gem.
This changes the Rakefile to remove the gemspec task, and move the logic
for determining files into the gemspec.
Some other changes related:
gem buildwith--outputto not require mving it after it's built-Ilibtoreferencetask, otherwise it fails to find ffakerCloses #190