Generate valid VINs #517
Merged
Generate valid VINs #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate VINs that are compliant with FMVSS 115, Part 595 standard.
marocchino
reviewed
Apr 8, 2022
| extend self | ||
|
|
||
| # https://en.wikibooks.org/wiki/Vehicle_Identification_Numbers_(VIN_codes)/World_Manufacturer_Identifier_(WMI) | ||
| VALID_WMI_REGIONS = [ ('A'..'C'), ('J'..'Z'), ('1'..'9') ].map(&:to_a).flatten |
There was a problem hiding this comment.
maybe)
Suggested change
| VALID_WMI_REGIONS = [ ('A'..'C'), ('J'..'Z'), ('1'..'9') ].map(&:to_a).flatten | |
| VALID_WMI_REGIONS = [ *'A'..'C', *'J'..'Z', *'1'..'9' ] |
marocchino
reviewed
Apr 8, 2022
Comment on lines
+57
to
+59
| weighted_sum = generated_vin.chars.each_with_index.map{|char, idx| | ||
| (TRANSLITERATION_VALUES[char.to_sym] || char).to_i * POSITION_WEIGHTS[idx] | ||
| }.reduce(:+) |
There was a problem hiding this comment.
I believe map ... reduce(:+) can replace with sum ...
[2] pry(main)> (1..10).map { |i| i*2 }.reduce(:+)
=> 110
[3] pry(main)> (1..10).sum { |i| i*2 }
=> 110
Suggested change
| weighted_sum = generated_vin.chars.each_with_index.map{|char, idx| | |
| (TRANSLITERATION_VALUES[char.to_sym] || char).to_i * POSITION_WEIGHTS[idx] | |
| }.reduce(:+) | |
| weighted_sum = generated_vin.chars.each_with_index.sum { |char, idx| | |
| (TRANSLITERATION_VALUES[char.to_sym] || char).to_i * POSITION_WEIGHTS[idx] | |
| } |
marocchino
reviewed
Apr 8, 2022
Comment on lines
+40
to
+54
| generated_vin = [ | ||
| [ # Manufacturer ID / WMI | ||
| fetch_sample(VALID_WMI_REGIONS), | ||
| 2.times.map{ fetch_sample(VALID_ALPHANUMERIC) }.join | ||
| ].join, | ||
| [ # Vehicle Description | ||
| 3.times.map{ fetch_sample(VALID_ALPHANUMERIC) }.join, | ||
| fetch_sample(VALID_ALPHA), | ||
| fetch_sample(VALID_ALPHANUMERIC) | ||
| ].join, | ||
| '0', # check digit placeholder | ||
| fetch_sample(VALID_YEAR_CHARS), # Year of Manufacture | ||
| fetch_sample(VALID_ALPHANUMERIC), # Plant ID | ||
| 6.times.map{ rand(10).to_s }.join # Serial number | ||
| ].join |
There was a problem hiding this comment.
I think fewer joins lead to better performance.
Suggested change
| generated_vin = [ | |
| [ # Manufacturer ID / WMI | |
| fetch_sample(VALID_WMI_REGIONS), | |
| 2.times.map{ fetch_sample(VALID_ALPHANUMERIC) }.join | |
| ].join, | |
| [ # Vehicle Description | |
| 3.times.map{ fetch_sample(VALID_ALPHANUMERIC) }.join, | |
| fetch_sample(VALID_ALPHA), | |
| fetch_sample(VALID_ALPHANUMERIC) | |
| ].join, | |
| '0', # check digit placeholder | |
| fetch_sample(VALID_YEAR_CHARS), # Year of Manufacture | |
| fetch_sample(VALID_ALPHANUMERIC), # Plant ID | |
| 6.times.map{ rand(10).to_s }.join # Serial number | |
| ].join | |
| generated_vin = [ | |
| # Manufacturer ID / WMI | |
| fetch_sample(VALID_WMI_REGIONS), | |
| *fetch_sample(VALID_ALPHANUMERIC, count: 2), | |
| # Vehicle Description | |
| *fetch_sample(VALID_ALPHANUMERIC, count: 3), | |
| fetch_sample(VALID_ALPHA), | |
| fetch_sample(VALID_ALPHANUMERIC), | |
| '0', # check digit placeholder | |
| fetch_sample(VALID_YEAR_CHARS), # Year of Manufacture | |
| fetch_sample(VALID_ALPHANUMERIC), # Plant ID | |
| *fetch_sample(0..9, count: 6) # Serial number | |
| ].join |
note: I know 6.times.map{ rand(10).to_s } is not same result with fetch_sample(0..9, count: 6). but That will be not problem in this case.
marocchino
reviewed
Apr 8, 2022
Comment on lines
+44
to
+49
| vin = FFaker::Vehicle.vin | ||
|
|
||
| assert_match(/\A[A-Z0-9]{17}\z/, vin) | ||
| assert_not_match(/[IOQ]/, vin) # VINs can't have these letters | ||
| assert_includes(FFaker::Vehicle::VIN::VALID_ALPHA, vin[6]) # passenger vehicle designator | ||
| assert_includes(FFaker::Vehicle::VIN::VALID_YEAR_CHARS, vin[9]) # check year character |
|
I will merge this and apply reviews. Thank you for this PR. (And sorry for late 🙈 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #310
Generate VINs that are compliant with FMVSS 115, Part 595 standard. Uses designated character set and format, and includes valid Check Digit.
The support code + constants for the VIN code is namespaced in to it's own module to avoid cluttering up the main file.
Note
test/test_vehicle.rb#test_vincould be brittle and the expected checksum could change if they was the VIN is generatedFFaker::Vehicle::VIN::vinis changed.