Fix crash in FFaker::Time#datetime when defining FFaker::Date module #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volosh1n
reviewed
May 27, 2022
test/test_time.rb
Outdated
Comment on lines
8
to
9
| extend FFaker::ModuleUtils | ||
| extend self |
There was a problem hiding this comment.
Shouldn't it live somewhere else? I mean, not in test folder
There was a problem hiding this comment.
Maybe something like ::Date is meaning here?
There was a problem hiding this comment.
I mean, I don't get the idea putting this module to test file. Overall I understand the issue
There was a problem hiding this comment.
Shouldn't it live somewhere else? I mean, not in test folder
I put the module there just to demonstrate the bug. I'll implement the FFaker::Date module with the methods we needed from our migration from Faker to FFaker.
Fix bugs with ::Date module clashing with FFaker::Date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining the FFaker::Date module makes FFaker::Time#datetime crash.
When migrating from Faker, we needed to add the module FFaker::Date to handle #backward and #forward differently than FFaker::Time.
FFaker::Time#datetime uses Date.new instead of ::Date.new so it crashes on trying to instantiate FFaker::Date which is a module.