8000 adjust uniqueness handling by iiwo · Pull Request #528 · ffaker/ffaker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

adjust uniqueness handling #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2023
Merged

adjust uniqueness handling #528

merged 1 commit into from
Apr 9, 2023
+102 −31

Conversation

iiwo
Copy link
Contributor
@iiwo iiwo commented Mar 20, 2023

@iiwo
adjust uniqueness handling
1d3d332 
- replace (slow) ObjectSpace with an instance record
- implement thread safety
- update README
@iiwo iiwo force-pushed the unique_values_adjustments branch from d74411b to 1d3d332 Compare March 20, 2023 18:10
@marocchino marocchino requested a review from Volosh1n March 21, 2023 05:57
m4rcelotoledo
m4rcelotoledo approved these changes Mar 21, 2023
View reviewed changes
Copy link
@m4rcelotoledo m4rcelotoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, LGTM 🚀

@marocchino marocchino merged commit 470f90d into ffaker:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marocchino marocchino marocchino approved these changes

@m4rcelotoledo m4rcelotoledo m4rcelotoledo approved these changes

@AlexWayfer AlexWayfer AlexWayfer approved these changes

@Volosh1n Volosh1n Awaiting requested review from Volosh1n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iiwo @marocchino @m4rcelotoledo @AlexWayfer
0